Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/179551806/convert to ts #11

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Chore/179551806/convert to ts #11

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ad62097
chore: converting to ts
ss-eggs Oct 6, 2021
5ccfc5a
chore: modified tsconfig
ss-eggs Oct 7, 2021
0dbb879
chore: added npmrc
ss-eggs Oct 13, 2021
bf31a32
chore: travis node14 yml update
ss-eggs Oct 13, 2021
0e85fab
chore: added missing declaration setting
ss-eggs Oct 13, 2021
14ce022
chore: goodeggs tsconfig update
ss-eggs Oct 19, 2021
7ee7281
chore: added tsfy changes. updated goodeggs ts config and formatters …
ss-eggs Oct 28, 2021
cd19364
chore: import moment and lodash libraries
missaelpadilla07 Nov 10, 2021
df3b753
chore: match the module for goodeggs-formatter for location
missaelpadilla07 Nov 10, 2021
cf550bb
chore: match the formats on goodeggs-formatter as the module for good…
missaelpadilla07 Nov 10, 2021
9230399
chore: remove clock and implement moment
missaelpadilla07 Nov 12, 2021
6724119
chore: modify test file to avoid travis issues
missaelpadilla07 Nov 12, 2021
0ace726
update yarn.lock file to avoid the travis issues
missaelpadilla07 Nov 12, 2021
4f7200f
Fix travis issues in .formatDateRange tests suite
missaelpadilla07 Nov 12, 2021
13f5d2c
fix `.formatDate` test suite
missaelpadilla07 Nov 12, 2021
7557d31
fix travis issues on `shortTime` and `orderCutoffDateTime` test suites
missaelpadilla07 Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"presets": [
["@babel/preset-env", {"targets": {"node": "current"}}],
"@babel/preset-typescript"
]
}
1 change: 1 addition & 0 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
.gitignore
.travis.yml
test/
lib/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this, we'll publish an unusable package that doesn't include the built code, which is the only useful thing to include!

1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
registry=https://registry.npmjs.org/
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
language: node_js
node_js:
- '8'
- "14"
8 changes: 3 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,22 @@ formatters for good eggs

[![Build Status](http://img.shields.io/travis/goodeggs/goodeggs-formatters.svg?style=flat-square)](https://travis-ci.org/goodeggs/goodeggs-formatters)


## Usage

```
npm install goodeggs-formatters
yarn install goodeggs-formatters
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No such thing!

Suggested change
yarn install goodeggs-formatters
yarn add goodeggs-formatters

```

```coffeescript
goodeggsFormatters = require 'goodeggs-formatters'
```


## Contributing

```
$ git clone https://github.com/goodeggs/goodeggs-formatters && cd goodeggs-formatters
$ npm install
$ npm test
$ yarn install
$ yarn test
```

_Module scaffold generated by [generator-goodeggs-npm](https://github.com/goodeggs/generator-goodeggs-npm)._
38 changes: 21 additions & 17 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
"Michael Kebbekus <[email protected]>",
"Michelle Becker <[email protected]>"
],
"publishConfig": {
"registry": "https://registry.npmjs.org/",
"access": "public"
},
Comment on lines +10 to +13
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this repo was also strangely public but published to our private registry. It's weird, but let's not change that now. Please undo this change!

"license": "Private",
"main": "lib/index.js",
"repository": {
Expand All @@ -25,27 +29,27 @@
"underscore": "^1.7.0"
},
"devDependencies": {
"babel-cli": "^6.26.0",
"babel-core": "^6.26.3",
"babel-preset-es2015": "^6.24.1",
"@babel/core": "^7.15.8",
"@babel/preset-env": "^7.15.8",
"@babel/preset-typescript": "^7.15.0",
"@goodeggs/tsconfig": "^1.0.0",
"@types/accounting": "^0.4.2",
"@types/jest": "^27.0.2",
"@types/node": "^16.10.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're testing on node 14 so maybe use 14 here?

"@types/sinon": "^10.0.4",
"@types/underscore": "^1.11.3",
"babel-jest": "^27.2.4",
"chai": "^1.10.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove? you switched to jest, so should be unused now

"jest": "^27.2.4",
"mocha": "~1.x.x",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, remove?

"sinon": "^1.12.2"
},
"babel": {
"sourceMaps": "inline",
"presets": [
"es2015"
]
"sinon": "^11.1.2",
"typescript": "^4.4.3"
},
"scripts": {
"compile": "babel -d lib/ src/",
"compile": "yarn clean && tsc -p tsconfig.build.json",
"clean": "rm -rf lib",
"prepublish": "npm run compile",
"pretest": "npm run compile",
"test": "mocha"
},
"publishConfig": {
"registry": "https://npm.goodeggs.com/",
"always-auth": true
"test": "yarn tsc && jest",
"tsc": "tsc"
}
}
Loading