Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: defer loading of dashboards list #5930

Merged
merged 1 commit into from
Feb 14, 2025
Merged

feat: defer loading of dashboards list #5930

merged 1 commit into from
Feb 14, 2025

Conversation

pbenes
Copy link
Contributor

@pbenes pbenes commented Feb 12, 2025

hidden under the same feature flag as previous deferred actions

risk: low
JIRA: STL-1104


Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.


Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

  • --backstop The command to run screen tests.
  • --integrated The command to run integrated tests against the live backend.
  • --isolated The command to run isolated tests against recordings.
  • --record The command to create new recordings for isolated tests.
  • --filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

hidden under the same feature flag as previous deferred actions
listed and accessible dashboards are the same on tiger

risk: low
JIRA: STL-1104
@pbenes pbenes requested a review from kandl as a code owner February 12, 2025 13:36
@pbenes
Copy link
Contributor Author

pbenes commented Feb 12, 2025

extended-test --isolated

Copy link

"extended-test --isolated" started. Check the progress here.

Copy link

✅ "extended-test --isolated" finished with result success. Check the results here.

Copy link
Contributor

@kandl kandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbenes pbenes merged commit 8fd6efb into master Feb 14, 2025
15 checks passed
@pbenes pbenes deleted the pb-no-dash-load branch February 14, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants