Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to secondary x axis for bar chart default sort #5778

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tjev
Copy link
Contributor

@Tjev Tjev commented Jan 9, 2025

When the default Bar chart sorting is being generated, the secondary_yaxis property is attempted to be retrieved from the properties mapping.
Based on current behavior of UI, as well as the supportedProperties definitions, it seems like the only secondary axis supported for the bar chart is on the X axis, instead of the Y axis.

risk: low
JIRA: CQ-987


Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.


Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

  • --backstop The command to run screen tests.
  • --integrated The command to run integrated tests against the live backend.
  • --isolated The command to run isolated tests against recordings.
  • --record The command to create new recordings for isolated tests.
  • --filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

When the default Bar chart sorting is being generated,
the secondary_yaxis property is attempted to be retrieved
from the properties mapping.
Based on current behavior of UI, as well as the supportedProperties
definitions, it seems like the only secondary axis supported for
the bar chart is on the X axis, instead of the Y axis.

risk: low
JIRA: CQ-987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant