Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-2229: Patron mode E2E & OCT-2229: Project admin mode E2E #605

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

OCT-2229: Patron mode E2E & OCT-2229: Project admin mode E2E #605

wants to merge 12 commits into from

Conversation

jmikolajczyk
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk requested a review from aziolek December 24, 2024 08:34
@jmikolajczyk jmikolajczyk self-assigned this Dec 24, 2024
@linear Linear
Copy link

linear bot commented Dec 24, 2024

OCT-2229 Patron mode E2E

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 24, 2024
@jmikolajczyk jmikolajczyk changed the base branch from develop to master December 24, 2024 13:41
@jmikolajczyk jmikolajczyk changed the title OCT-2229: Patron mode E2E OCT-2229: Patron mode E2E & OCT-2229: Project admin mode E2E Dec 24, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 24, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12479283701 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 24, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 24, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12482820690 failed 💥

housekeeper-bot
housekeeper-bot requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12482820690 failed 💥

aziolek
aziolek previously approved these changes Jan 2, 2025
View reviewed changes
@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jan 10, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 10, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12710817929 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jan 13, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 14, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12755498966 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jan 15, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 15, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12787137378 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 16, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 16, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12804668123 failed 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housekeeper-bot housekeeper-bot housekeeper-bot requested changes

@aziolek aziolek aziolek left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@jmikolajczyk jmikolajczyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikolajczyk @aziolek @housekeeper-bot