Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-2246: Migrate logic for /epochs #579

Merged

Conversation

kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@kgarbacinski kgarbacinski requested a review from adam-gf December 9, 2024 11:50
@kgarbacinski kgarbacinski self-assigned this Dec 9, 2024
Copy link

linear bot commented Dec 9, 2024

OCT-2246 Migrate logic

Copy link
Contributor

@adam-gf adam-gf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comments. I'd align on important points, minors are up to you to decide waht to do with those.

@kgarbacinski kgarbacinski force-pushed the kacper/chore/cot-2246-rewrite-epochs-logic-to-fastapi branch from f8c721f to 84cf834 Compare December 10, 2024 10:19
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 10, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 10, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12254265084 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 10, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 10, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12258728814 failed 💥

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 10, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 10, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12265520137 failed 💥

@adam-gf adam-gf added the request-approval Request approval from the Housekeeper label Dec 11, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 11, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12274856476 failed 💥

@aziolek aziolek merged commit 122bbe9 into develop Dec 11, 2024
91 of 95 checks passed
@aziolek aziolek deleted the kacper/chore/cot-2246-rewrite-epochs-logic-to-fastapi branch December 11, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants