Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE] 0.5.0 #351

Merged
merged 16 commits into from
Jul 22, 2024
Merged

[RELEASE] 0.5.0 #351

merged 16 commits into from
Jul 22, 2024

Conversation

aziolek
Copy link
Member

@aziolek aziolek commented Jul 22, 2024

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@aziolek aziolek self-assigned this Jul 22, 2024
@aziolek aziolek marked this pull request as ready for review July 22, 2024 13:53
@aziolek aziolek requested a review from housekeeper-bot as a code owner July 22, 2024 13:53
adam-gf
adam-gf approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@adam-gf adam-gf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aziolek aziolek merged commit f6cba22 into master Jul 22, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-gf adam-gf adam-gf approved these changes

@kgarbacinski kgarbacinski kgarbacinski approved these changes

@housekeeper-bot housekeeper-bot Awaiting requested review from housekeeper-bot housekeeper-bot is a code owner

Assignees

@aziolek aziolek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aziolek @kgarbacinski @adam-gf @mike-code @paulperegud