Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Do not fetch project donors outside AW #108

Merged
merged 9 commits into from
Mar 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions client/src/hooks/queries/donors/useProjectDonors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,9 @@ export default function useProjectDonors(
});

return useQuery({
enabled: !!projectAddress && (epoch !== undefined || !!(currentEpoch && currentEpoch > 1)),
queryFn: () =>
apiGetProjectDonors(
projectAddress,
epoch || (isDecisionWindowOpen ? currentEpoch! - 1 : currentEpoch!),
),
queryKey: QUERY_KEYS.projectDonors(
projectAddress,
epoch || (isDecisionWindowOpen ? currentEpoch! - 1 : currentEpoch!),
),
enabled: !!projectAddress && (!!currentEpoch && currentEpoch > 1) && (isDecisionWindowOpen === true || epoch !== undefined),
queryFn: () => apiGetProjectDonors(projectAddress, epoch || currentEpoch! - 1),
queryKey: QUERY_KEYS.projectDonors(projectAddress, epoch || currentEpoch! - 1),
select: response => mapDataToProjectDonors(response),
staleTime: Infinity,
...options,
Expand Down
21 changes: 11 additions & 10 deletions client/src/hooks/queries/donors/useProjectsDonors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { mapDataToProjectDonors } from './utils';
export default function useProjectsDonors(epoch?: number): {
data: { [key: string]: ProjectDonor[] };
isFetching: boolean;
isSuccess: boolean;
} {
const { data: currentEpoch } = useCurrentEpoch();
const { data: projectsAddresses } = useProjectsContract(epoch);
Expand All @@ -21,16 +22,13 @@ export default function useProjectsDonors(epoch?: number): {

const projectsDonorsResults: UseQueryResult<ProjectDonor[]>[] = useQueries({
queries: (projectsAddresses || []).map(projectAddress => ({
enabled: !!projectsAddresses && isDecisionWindowOpen !== undefined,
queryFn: () =>
apiGetProjectDonors(
projectAddress,
epoch || (isDecisionWindowOpen ? currentEpoch! - 1 : currentEpoch!),
),
queryKey: QUERY_KEYS.projectDonors(
projectAddress,
epoch || (isDecisionWindowOpen ? currentEpoch! - 1 : currentEpoch!),
),
enabled:
!!projectsAddresses &&
!!currentEpoch &&
currentEpoch > 1 &&
(isDecisionWindowOpen === true || epoch !== undefined),
queryFn: () => apiGetProjectDonors(projectAddress, epoch || currentEpoch! - 1),
queryKey: QUERY_KEYS.projectDonors(projectAddress, epoch || currentEpoch! - 1),
select: response => mapDataToProjectDonors(response),
})),
});
Expand All @@ -46,6 +44,7 @@ export default function useProjectsDonors(epoch?: number): {
return {
data: {},
isFetching,
isSuccess: false,
};
}

Expand All @@ -57,5 +56,7 @@ export default function useProjectsDonors(epoch?: number): {
};
}, {}),
isFetching: false,
// Ensures projectsDonorsResults is actually fetched with data, and not just an object with undefined values.
isSuccess: !projectsDonorsResults.some(element => !element.isSuccess),
};
}
17 changes: 12 additions & 5 deletions client/src/hooks/queries/useProjectsIpfsWithRewards.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import env from 'env';
import { ExtendedProject } from 'types/extended-project';
import getSortedElementsByTotalValueOfAllocationsAndAlphabetical from 'utils/getSortedElementsByTotalValueOfAllocationsAndAlphabetical';

Expand All @@ -18,7 +19,7 @@ export default function useProjectsIpfsWithRewards(epoch?: number): {
isFetching: boolean;
} {
// TODO OCT-1270 TODO OCT-1312 Remove this override.
const epochOverrideForDataFetch = epoch === 2 ? 3 : epoch;
const epochOverrideForDataFetch = env.network === 'Mainnet' && epoch === 2 ? 3 : epoch;

const { data: projectsAddresses, isFetching: isFetchingProjectsContract } =
useProjectsContract(epochOverrideForDataFetch);
Expand All @@ -31,7 +32,12 @@ export default function useProjectsIpfsWithRewards(epoch?: number): {
isFetching: isFetchingMatchedProjectRewards,
isRefetching: isRefetchingMatchedProjectRewards,
} = useMatchedProjectRewards(epoch);
const { data: projectsDonors, isFetching: isFetchingProjectsDonors } = useProjectsDonors(epoch);

const {
data: projectsDonors,
isFetching: isFetchingProjectsDonors,
isSuccess: isSuccessProjectsDonors,
} = useProjectsDonors(epoch);

const isFetching =
isFetchingProjectsContract ||
Expand All @@ -54,10 +60,11 @@ export default function useProjectsIpfsWithRewards(epoch?: number): {
* passed threshold. For those that did not, we reduce on their donors and get the value.
*/
const totalValueOfAllocations =
projectMatchedProjectRewards?.sum ||
projectsDonors[project.address].reduce((acc, curr) => acc + curr.amount, BigInt(0));
projectMatchedProjectRewards?.sum || isSuccessProjectsDonors
? projectsDonors[project.address].reduce((acc, curr) => acc + curr.amount, BigInt(0))
: BigInt(0);
return {
numberOfDonors: projectsDonors[project.address].length,
numberOfDonors: isSuccessProjectsDonors ? projectsDonors[project.address].length : 0,
percentage: projectMatchedProjectRewards?.percentage,
totalValueOfAllocations,
...project,
Expand Down