Oct-2336: Processing of all pending multisigs fails when any is corru…

…pted (#638)

backend/app/modules/facades/confirm_multisig.py

@@ -1,5 +1,7 @@
 import json
 
+from flask import current_app as app
+
 from app.modules.multisig_signatures.controller import (
     apply_pending_tos_signature,
     apply_pending_allocation_signature,
@@ -19,19 +21,29 @@ def confirm_multisig():
     approvals = approve_pending_signatures()
 
     for tos_signature in approvals.tos_signatures:
-        tos_controller.post_user_terms_of_service_consent(
-            tos_signature.user_address,
-            tos_signature.signature,
-            tos_signature.ip_address,
-        )
-        apply_pending_tos_signature(tos_signature.id)
+        # We don't want to fail the whole process if one TOS fails
+        try:
+            tos_controller.post_user_terms_of_service_consent(
+                tos_signature.user_address,
+                tos_signature.signature,
+                tos_signature.ip_address,
+            )
+            apply_pending_tos_signature(tos_signature.id)
+
+        except Exception as e:
+            app.logger.error(f"Error confirming TOS signature: {e}")
 
     for allocation_signature in approvals.allocation_signatures:
-        message = json.loads(allocation_signature.message)
-        message["signature"] = allocation_signature.signature
-        allocations_controller.allocate(
-            allocation_signature.user_address,
-            message,
-            is_manually_edited=message.get("isManuallyEdited"),
-        )
-        apply_pending_allocation_signature(allocation_signature.id)
+        # We don't want to fail the whole process if one allocation fails
+        try:
+            message = json.loads(allocation_signature.message)
+            message["signature"] = allocation_signature.signature
+            allocations_controller.allocate(
+                allocation_signature.user_address,
+                message,
+                is_manually_edited=message.get("isManuallyEdited"),
+            )
+            apply_pending_allocation_signature(allocation_signature.id)
+
+        except Exception as e:
+            app.logger.error(f"Error confirming allocation signature: {e}")