-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use client authn on device auth request #757
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 1549187) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/632135. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/632135. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/632135. |
According to https://datatracker.ietf.org/doc/html/rfc8628#section-3.1, the device auth request must include client authentication. Fixes golang#685
1549187
to
dcc463a
Compare
This PR (HEAD: dcc463a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/632135. Important tips:
|
Message from Nikos Sklikas: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/632135. |
According to https://datatracker.ietf.org/doc/html/rfc8628#section-3.1:
This PR introduces client authentication on the device auth request. Same mechanism used for client authentication on the token endpoint is used on the device auth request as well.
The logic for making the device auth request was moved to the internal package similar to the token request logic, so that we can re-use the
lookupAuthStyle
cache.Fixes #685