Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add technical definition for manifoldness #10419

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

tetrapod00
Copy link
Contributor

Part of #10417. Also documents changes for godotengine/godot#94321.

@tetrapod00 tetrapod00 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:3d labels Dec 17, 2024
@tetrapod00 tetrapod00 added this to the 4.4 milestone Dec 17, 2024
@tetrapod00 tetrapod00 requested a review from fire December 17, 2024 21:10
@fire
Copy link
Member

fire commented Dec 19, 2024

What do we need to do to get this completed?

@tetrapod00
Copy link
Contributor Author

tetrapod00 commented Dec 19, 2024

If it's all correct to you now, this is mergable, but I'd like to leave it up for a day or so before merging to give others a chance to review, since I did write it myself.

Copy link

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tetrapod00
Copy link
Contributor Author

Pushed a minor wording correction.

@tetrapod00 tetrapod00 merged commit 5eebe5f into godotengine:master Dec 23, 2024
1 check passed
@tetrapod00
Copy link
Contributor Author

Merged. Thanks fire and especially elalish for taking the time to review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants