Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflow: Use new setup-godot-cpp github action from godot-cpp submodule. #70

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Ivorforce
Copy link
Contributor

@Ivorforce Ivorforce commented Nov 27, 2024

Follow up of #68.

With this PR, the GH actions are changed to use setup-godot-cpp from the godot-cpp repository (local version). This lifts the same burden from this repository, making it more future proof and easier to maintain.

@Ivorforce
Copy link
Contributor Author

Sorry for the repeated pushes... Somehow, I got stuck with git issues regarding the submodule. I simply don't understand those things...

Anyway, the PR is updated to use the latest godot-cpp commit now. It should still run through. But we still shouldn't merge because that would upgrade the repo to godot 4.x. Should merge until the change is cherry-picked to 4.3 at least.

@paddy-exe paddy-exe added the enhancement New feature or request label Dec 12, 2024
@Ivorforce Ivorforce force-pushed the gh-action-setup-godot-cpp branch from 0b5818e to fb2cb48 Compare January 29, 2025 19:01
@Ivorforce
Copy link
Contributor Author

Ivorforce commented Jan 29, 2025

I updated godot-cpp to f3a1a2fd458dfaf4de08c906f22a2fe9e924b16f (4.3 branch). It should be mergable now!

Edit: As promised earlier, I also updated the readme to reflect the new action. I think it is better to document its structure in the file itself (lest we have its content twice), so I removed the copy from README.md added some comments in builds.yml. Open to adding more comments!

@Ivorforce Ivorforce force-pushed the gh-action-setup-godot-cpp branch from fb2cb48 to 56db50d Compare January 29, 2025 19:15
README.md Outdated Show resolved Hide resolved
@Ivorforce Ivorforce force-pushed the gh-action-setup-godot-cpp branch from 56db50d to 9bd7df9 Compare February 3, 2025 11:51
@Ivorforce Ivorforce force-pushed the gh-action-setup-godot-cpp branch from 9bd7df9 to 5ea544e Compare February 3, 2025 11:53
Copy link
Collaborator

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@paddy-exe paddy-exe merged commit f9a50b5 into godotengine:main Feb 3, 2025
23 checks passed
@Ivorforce Ivorforce deleted the gh-action-setup-godot-cpp branch February 3, 2025 23:23
@Ughuuu
Copy link
Contributor

Ughuuu commented Feb 8, 2025

Ok, this once again broke my builds, since it deleted the build action. I guess I will write it manually for all my repos since it changes so often and breaks compatibility.

@Ivorforce
Copy link
Contributor Author

Ivorforce commented Feb 8, 2025

@Ughuuu This PR actually addresses that exact issue :)
The godot-cpp repo has a setup-godot-cpp github action now. I would recommend you adjust your workflow the exact same way as this PR does to the template workflow. This should make your workflow future proof, and stop breaking your builds.

@Ughuuu
Copy link
Contributor

Ughuuu commented Feb 8, 2025

I see the idea, but not rlly, it's not versioned still, no?
./godot-cpp/.github/actions/setup-godot-cpp
it's not @v1 or so on..

@Ivorforce
Copy link
Contributor Author

Since the new version is using a local action (in ./godot-cpp), it won't change unexpectedly as long as you don't update godot-cpp. Versioning isn't required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants