-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Workflow: Use new setup-godot-cpp github action from godot-cpp submodule. #70
GitHub Workflow: Use new setup-godot-cpp github action from godot-cpp submodule. #70
Conversation
45f0369
to
0b5818e
Compare
Sorry for the repeated pushes... Somehow, I got stuck with git issues regarding the submodule. I simply don't understand those things... Anyway, the PR is updated to use the latest godot-cpp commit now. It should still run through. But we still shouldn't merge because that would upgrade the repo to godot 4.x. Should merge until the change is cherry-picked to 4.3 at least. |
0b5818e
to
fb2cb48
Compare
I updated godot-cpp to f3a1a2fd458dfaf4de08c906f22a2fe9e924b16f (4.3 branch). It should be mergable now! Edit: As promised earlier, I also updated the readme to reflect the new action. I think it is better to document its structure in the file itself (lest we have its content twice), so I removed the copy from |
fb2cb48
to
56db50d
Compare
56db50d
to
9bd7df9
Compare
9bd7df9
to
5ea544e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
Ok, this once again broke my builds, since it deleted the build action. I guess I will write it manually for all my repos since it changes so often and breaks compatibility. |
@Ughuuu This PR actually addresses that exact issue :) |
I see the idea, but not rlly, it's not versioned still, no? |
Since the new version is using a local action (in ./godot-cpp), it won't change unexpectedly as long as you don't update godot-cpp. Versioning isn't required. |
Follow up of #68.
With this PR, the GH actions are changed to use setup-godot-cpp from the godot-cpp repository (local version). This lifts the same burden from this repository, making it more future proof and easier to maintain.