adjust cookie parser invocation to earlier in the lifecycle chain (#1009

) * adjust cookie parser invocation to earlier in the lifecycle chain * CHANGELOG
godaddy · Jan 13, 2025 · e71aa0f · e71aa0f
1 parent ee81693
commit e71aa0f
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/packages/gasket-plugin-express/CHANGELOG.md b/packages/gasket-plugin-express/CHANGELOG.md
@@ -1,5 +1,7 @@
 # `@gasket/plugin-express`
 
+- adjust cookie parser invocation to earlier in the lifecycle chain ([#1009])
+
 ### 7.1.1
 
 - Ensure cookies are parsed ([#1001])
@@ -146,3 +148,4 @@
 [#959]: https://github.com/godaddy/gasket/pull/959
 [#969]: https://github.com/godaddy/gasket/pull/969
 [#1001]: https://github.com/godaddy/gasket/pull/1001
+[#1009]: https://github.com/godaddy/gasket/pull/1009
diff --git a/packages/gasket-plugin-express/lib/create-servers.js b/packages/gasket-plugin-express/lib/create-servers.js
@@ -8,7 +8,6 @@
  */
 module.exports = async function createServers(gasket, serverOpts) {
   const app = gasket.actions.getExpressApp();
-  app.use(require('cookie-parser')());
 
   await gasket.exec('express', app);
 

diff --git a/packages/gasket-plugin-express/lib/index.js b/packages/gasket-plugin-express/lib/index.js
@@ -17,7 +17,16 @@ const plugin = {
     getExpressApp(gasket) {
       const express = require('express');
       const { http2 } = gasket.config;
-      app ??= http2 ? require('http2-express')(express) : express();
+
+      if (!app) {
+        if (http2) {
+          app = require('http2-express')(express);
+        } else {
+          app = express();
+        }
+
+        app.use(require('cookie-parser')());
+      }
 
       return app;
     }

diff --git a/packages/gasket-plugin-express/test/plugin.test.js b/packages/gasket-plugin-express/test/plugin.test.js
@@ -87,7 +87,7 @@ describe('createServers', () => {
   });
 
   it('attaches cookie parser middleware', async function () {
-    await plugin.hooks.createServers(gasket, {});
+    plugin.actions.getExpressApp(gasket);
     expect(app.use).toHaveBeenCalledWith(cookieParserMiddleware);
   });