Merge pull request #47 from paulspringett/fix-transition-to-swallowin…

…g-user-exceptions

Fix transition to swallowing user exceptions

lib/statesman/machine.rb

@@ -196,7 +196,7 @@ def execute(phase, initial_state, new_state, transition)
 
     def transition_to(new_state, metadata = nil)
       self.transition_to!(new_state, metadata)
-    rescue
+    rescue TransitionFailedError, GuardFailedError
       false
     end
 

spec/statesman/machine_spec.rb

@@ -440,6 +440,21 @@ def after_initialize; end
       end
       it { should be_false }
     end
+
+    context "when a non statesman exception is raised" do
+      before do
+        instance.stub(:transition_to!).and_raise(RuntimeError,
+                                                 'user defined exception')
+      end
+
+      it "should not rescue the exception" do
+        expectation = expect do
+          instance.transition_to(:some_state, metadata)
+        end
+
+        expectation.to raise_error(RuntimeError, 'user defined exception')
+      end
+    end
   end
 
   shared_examples "a callback filter" do |definer, phase|