-
-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sources: prevent deletion of built-in source #12914
Open
dominic-r
wants to merge
8
commits into
goauthentik:main
Choose a base branch
from
dominic-r:sdko/sources/no-delete-built-in
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
sources: prevent deletion of built-in source #12914
dominic-r
wants to merge
8
commits into
goauthentik:main
from
dominic-r:sdko/sources/no-delete-built-in
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12914 +/- ##
==========================================
+ Coverage 92.70% 92.74% +0.04%
==========================================
Files 785 785
Lines 39580 39586 +6
==========================================
+ Hits 36692 36716 +24
+ Misses 2888 2870 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dominic R <[email protected]>
Signed-off-by: Dominic R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdko/sources/no-delete-built-in
What?
This PR modifies
renderToolbarSelected
to disable the "Delete" button for the built-in authentik login source. While the button will reappear after a server restart, the change is intended as a precaution to prevent potential issues by blocking deletion. Furthermore, it adds a function to theSourceViewSet
class to return an error when attmpting to delete the source using the API url.Testing:
Details
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)