Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BisBuddy to testing #5421

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add BisBuddy to testing #5421

wants to merge 4 commits into from
+13 −0

Conversation

RajahOmen
Copy link

BisBuddy is a plugin to help make gearing easier by highlighting items in various interfaces that are needed for your BiS gearsets. See the readme for more info and images of it working

@bleatbot bleatbot enabled auto-merge (squash) February 3, 2025 18:15
@bleatbot
Copy link
Collaborator

bleatbot commented Feb 3, 2025 •
edited
Loading

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@philpax
Copy link
Contributor

philpax commented Feb 3, 2025

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Feb 3, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ BisBuddy [testing-live] 0c25fa1 v0.0.0.1 - Repo (New plugin)
6 Needs (⚠️ 3 UNREVIEWED)
Type Name Version Reviewed by
NuGet Fastenshtein 1.0.10 ⚠️ NEW
NuGet LinearAssignment 1.2.0 ⚠️ NEW
NuGet Lumina.Generated 5.30.2 ⚠️ NEW
NuGet Lumina 5.5.0 philpax
2 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. size-large Diff for this PR is large. labels Feb 3, 2025
@philpax
Copy link
Contributor

philpax commented Feb 3, 2025

This plugin is now in the plugin review queue; we hope to get back to you soon!

@philpax philpax added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Feb 3, 2025
auto-merge was automatically disabled February 4, 2025 00:14

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Feb 4, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ BisBuddy [testing-live] bb4b33e v0.0.0.1 - Repo (New plugin)
6 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
NuGet Fastenshtein 1.0.10 ⚠️ NEW
NuGet LinearAssignment 1.2.0 ⚠️ NEW
NuGet Lumina 5.5.0 philpax
NuGet Lumina.Excel 7.1.3 philpax
2 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot removed pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Feb 4, 2025
@bleatbot
Copy link
Collaborator

bleatbot commented Feb 4, 2025 •
edited
Loading

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ BisBuddy [testing-live] 77a8ce9 v0.0.0.2 - Repo (New plugin)
6 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
NuGet Fastenshtein 1.0.10 ⚠️ NEW
NuGet LinearAssignment 1.2.0 ⚠️ NEW
NuGet Lumina 5.5.0 philpax
NuGet Lumina.Excel 7.1.3 philpax
2 hidden needs (known safe NuGet packages).
Show log - Review

@philpax philpax added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. completed-rules-compliance This plugin is compliant with all rules. and removed pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. labels Feb 9, 2025
@RajahOmen
Update manifest.toml
76b7d80 
Update to latest commit, with features and bugfixes
@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ BisBuddy [testing-live] 1c9f70e v0.0.3.0 - Repo (New plugin)
6 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
NuGet Fastenshtein 1.0.10 ⚠️ NEW
NuGet LinearAssignment 1.2.0 ⚠️ NEW
NuGet Lumina 5.5.0 philpax
NuGet Lumina.Excel 7.1.3 philpax
2 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot removed pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. labels Feb 11, 2025
@RajahOmen
Copy link
Author

  • Added ability to customize highlight color in config
  • Added search for gearpiece items in inventory
  • Added configurable behavior for matching behavior of auto-assignment
  • resx localization (en impl. only)
  • bugfixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reiichi001 reiichi001

Labels
completed-rules-compliance This plugin is compliant with all rules. new plugin This is a new plugin. size-large Diff for this PR is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RajahOmen @bleatbot @philpax @reiichi001 @ngarnier1a