add support for driver.NamedValueChecker on driver connection #887
Conversation
Based on the documentation calling ErrSkip will cause the DefaultParameterConverter to be used instead. The driver will write a legal payload, but I'm going to update the tests for this. |
|
|
||
| // the NamedValueChecker will return ErrSkip for types that are NOT uint64, so make | ||
| // sure those make it to the server ok first. | ||
| int32Stmt, err := conn.Prepare("select ?") |
There was a problem hiding this comment.
lines 149-159 tests that the nameValueChecker falls back to the driver.DefaultParameterConverter if ErrSkip is returned.
|
|
||
| conn.Close() | ||
| } | ||
|
|
||
| func TestDriverOptions_namedValueChecker(t *testing.T) { | ||
| AddNamedValueChecker(func(nv *sqlDriver.NamedValue) error { | ||
| rv := reflect.ValueOf(nv.Value) |
There was a problem hiding this comment.
I also checked it can be written as
_, ok := nv.Value.(uint64)
if !ok {
return sqlDriver.ErrSkip
}
return nil
Maybe it's faster to use golang's built-in type cast rather than reflection in your application.
There was a problem hiding this comment.
Oh yea thanks. This is much better.
Unrelated question, how often do you, or what is the criteria to, create a tag for a new version?
There was a problem hiding this comment.
As a user, our project always uses "master" branch 😂 So generally when other contributors ask for a release I ping @atercattus to release it.
This PR is to address issue #886, which prevents a client from using custom value types, specifically
uint64in prepared statements.