Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Driver args for compression and connection read/write timeouts #885

Merged
merged 22 commits into from
Jun 6, 2024

Conversation

dvilaverde
Copy link
Contributor

I'm proposing this PR to address the issue #859 which asks for the ability to enable compression in the connection DSN. I've also added a few other properties:

  • compress
  • readTimeout
  • timeout
  • writeTimeout

and I've updated the README.md.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dveeden dveeden requested review from lance6716 and atercattus June 4, 2024 18:58
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
client/conn.go Show resolved Hide resolved
driver/driver.go Show resolved Hide resolved
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

packet/conn.go Show resolved Hide resolved
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm. Thanks

driver/driver.go Outdated Show resolved Hide resolved
@lance6716 lance6716 merged commit b13191f into go-mysql-org:master Jun 6, 2024
13 checks passed
@dvilaverde dvilaverde deleted the driver_args branch June 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants