fix(sd): default namespace is graphite

go-graphite · Nov 2, 2023 · 44c29e6 · 44c29e6
1 parent c47e8c8
commit 44c29e6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/sd/nginx/nginx.go b/sd/nginx/nginx.go
@@ -60,6 +60,9 @@ type Nginx struct {
 }
 
 func New(url, namespace, hostname string, logger *zap.Logger) *Nginx {
+	if namespace == "" {
+		namespace = "graphite"
+	}
 	sd := &Nginx{
 		logger:     logger,
 		body:       make([]byte, 128),

diff --git a/sd/nginx/nginx_test.go b/sd/nginx/nginx_test.go
@@ -35,7 +35,7 @@ func TestNginx(t *testing.T) {
 	logger := zapwriter.Default()
 
 	sd1 := New("http://127.0.0.1:8500/v1/kv/upstreams", "graphite", hostname1, logger)
-	sd2 := New("http://127.0.0.1:8500/v1/kv/upstreams", "graphite", hostname2, logger)
+	sd2 := New("http://127.0.0.1:8500/v1/kv/upstreams", "", hostname2, logger)
 
 	err := sd1.Clear("", "")
 	require.True(t, err == nil || err == utils.ErrNotFound, err)
@@ -170,7 +170,7 @@ func TestNginxDC(t *testing.T) {
 
 	logger := zapwriter.Default()
 
-	sd1 := New("http://127.0.0.1:8500/v1/kv/upstreams", "graphite", hostname1, logger)
+	sd1 := New("http://127.0.0.1:8500/v1/kv/upstreams", "", hostname1, logger)
 	sd2 := New("http://127.0.0.1:8500/v1/kv/upstreams", "graphite", hostname2, logger)
 
 	err := sd1.Clear("", "")