Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some trivial problems and TODOs #33473

Merged
merged 3 commits into from
Feb 2, 2025
Merged

chore: fix some trivial problems and TODOs #33473

merged 3 commits into from
Feb 2, 2025
+18 −104

Conversation

wxiaoguang
Copy link
Contributor

  1. Fix incorrect MentionCount (actually it seems to be deadcode, affects nothing)
  2. Remove fallback sha1 support for time limit token
  3. Use route middleware reqRepoActionsWriter for ArtifactsDeleteView
  4. Use clearer message "Failed to authenticate user" instead of "Verify" when auth fails
  5. tests/integration/benchmarks_test.go is not quite right, actually it is never used, so delete it.
  6. Remove or update TODO comments

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 2, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 2, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 2, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 2, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Feb 2, 2025
@wxiaoguang wxiaoguang mentioned this pull request Feb 2, 2025
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 2, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 2, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 2, 2025
@lunny lunny enabled auto-merge (squash) February 2, 2025 17:51
@lunny lunny merged commit 5dddcc1 into go-gitea:main Feb 2, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 2, 2025
@wxiaoguang wxiaoguang deleted the fix-todo branch February 2, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @delvh @GiteaBot