Add tests for webhook and fix some webhook bugs (#33396) #33442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
github-actions
bot
added
modifies/api
This PR created a mock webhook server in the tests and added integration tests for generic webhooks. It also fixes bugs in package webhooks and pull request comment webhooks.
lunny
force-pushed
the
lunny/add_webhook_test2
branch
from
df2d467 to
6369446
Compare
hiifong
approved these changes
Feb 1, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Feb 2, 2025
| @@ -480,7 +424,7 @@ type PackagePayload struct { | |||
| Action HookPackageAction `json:"action"` | |||
| Repository *Repository `json:"repository"` | |||
| Package *Package `json:"package"` | |||
| Organization *User `json:"organization"` | |||
| Organization *Organization `json:"organization"` | |||
There was a problem hiding this comment.
I prefer to consider it a bug of the previous implementation, not a feature change. So it's not a break change although it will make something break because the previous implementation is wrong. Compare the two structs,
User have many fields which should not belong to Organization, i.e.
// Is the user an administrator
IsAdmin bool `json:"is_admin"`
// swagger:strfmt date-time
LastLogin time.Time `json:"last_login,omitempty"`
// Is user active
IsActive bool `json:"active"`
// Is user login prohibited
ProhibitLogin bool `json:"prohibit_login"`
...But I'm OK if you prefer to add a breaking label and description.
There was a problem hiding this comment.
Hmm yes, most useful fields are there
There was a problem hiding this comment.
But to backport, we need to mention that the struct has changed, to avoid wasting users' time
wxiaoguang
approved these changes
Feb 2, 2025
GiteaBot
added
lgtm/done
lunny
added
pr/breaking
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR created a mock webhook server in the tests and added integration tests for generic webhooks.
It also fixes bugs in package webhooks and pull request comment webhooks.
This also corrected an error on the package webhook. The previous implementation uses a
Userstruct as an organization, now it has been corrected but it will not be consistent with the previous implementation, some fields which not belong to the organization have been removed.Backport #33396
Backport part of #33337