-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Added pull review read only endpoints #10005
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// Copyright 2020 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package structs | ||
|
||
import ( | ||
"time" | ||
) | ||
|
||
// PullRequestReview represents a pull request review | ||
type PullRequestReview struct { | ||
ID int64 `json:"id"` | ||
PRURL string `json:"pull_request_url"` | ||
Reviewer *User `json:"user"` | ||
Body string `json:"body"` | ||
CommitID string `json:"commit_id"` | ||
Type string `json:"type"` | ||
|
||
// swagger:strfmt date-time | ||
Created time.Time `json:"created_at"` | ||
|
||
// TODO: is there a way to get a URL to the review itself? | ||
// HTMLURL string `json:"html_url"` | ||
} | ||
|
||
// PullRequestReviewComment represents a comment on a pull request | ||
type PullRequestReviewComment struct { | ||
ID int64 `json:"id"` | ||
URL string `json:"url"` | ||
PRURL string `json:"pull_request_url"` | ||
ReviewID int64 `json:"pull_request_review_id"` | ||
Path string `json:"path"` | ||
CommitID string `json:"commit_id"` | ||
DiffHunk string `json:"diff_hunk"` | ||
LineNum uint64 `json:"position"` | ||
OldLineNum uint64 `json:"original_position"` | ||
Reviewer *User `json:"user"` | ||
Body string `json:"body"` | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add state info too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o it still a draft :D - the start looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about naming that
state
, but it was so misleading, that I've gone withtype
.just looks strange.
But i can rename this if wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair point ... just did a comparsion with the github api ...
and beside COMMENT, PENDING, APPROVED, REJECT could be interpreted as state ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add field
submitted_at
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stale
andofficial
can also be interesting fields (GH doesn't have them).Also possibility to get list of only latest review of each reviewer would be good, as that is what is seen on PR page.