fix: path parsing issue #371
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenQuim
requested changes
Jan 23, 2025
Comment on lines
-10
to
+13
| func NewRoute[T, B any](method, path string, handler any, e *Engine, options ...func(*BaseRoute)) Route[T, B] { | ||
| func NewRoute[T, B any](method, path string, handler any, e *Engine, config RouteConfig, options ...func(*BaseRoute)) Route[T, B] { | ||
| if config.StripTrailingSlash && len(path) > 1 { | ||
| path = strings.TrimRight(path, "/") | ||
| } |
There was a problem hiding this comment.
Please don't change the Route signature, and add it as an option as the other ones
Comment on lines
+13
to
+16
| type RouteConfig struct { | ||
| StripTrailingSlash bool | ||
| } | ||
|
|
There was a problem hiding this comment.
Use a Route Option please, cf the BaseRoute struct and the option.go file
Comment on lines
+87
to
+89
| if s.StripTrailingSlash && len(r.URL.Path) > 1 { | ||
| r.URL.Path = strings.TrimRight(r.URL.Path, "/") | ||
| } |
There was a problem hiding this comment.
Is the length condition useful?
There was a problem hiding this comment.
Yes it is, to avoid strip a route like '/'
There was a problem hiding this comment.
Mmmh good idea! Can you make this comparison more explicit?
Comment on lines
+85
to
+87
|
|
||
| // StripTrailingSlash determines if trailing slashes should be removed from routes and requests | ||
| StripTrailingSlash bool |
There was a problem hiding this comment.
Please just use a route option, you can delete it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #366
@EwenQuim
I introduced a new server property
StripTrailingSlashthat can be activated by usingwithStripTrailingSlashthis helps remove trailing slash from defined routes and request