Add method to override the images sector size #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
reviewed
Feb 14, 2025
|
Would be great to have a test as well, but that can come later |
julien-massot
force-pushed
the
main
branch
3 times, most recently
from
481bf33 to
89bdc3e
Compare
I have a patch to add the test, I will push it after this one. |
julien-massot
pushed a commit
to julien-massot/debos
that referenced
this pull request
Feb 18, 2025
Will remove when go-debos/fakemachine#222 is done. Signed-off-by: Julien Massot <[email protected]>
julien-massot
pushed a commit
to julien-massot/debos
that referenced
this pull request
Feb 18, 2025
Will remove when go-debos/fakemachine#222 is done. Signed-off-by: Julien Massot <[email protected]>
julien-massot
pushed a commit
to julien-massot/debos
that referenced
this pull request
Feb 18, 2025
Will remove when go-debos/fakemachine#222 is done. Signed-off-by: Julien Massot <[email protected]>
julien-massot
pushed a commit
to julien-massot/debos
that referenced
this pull request
Feb 19, 2025
Will remove when go-debos/fakemachine#222 is done. Signed-off-by: Julien Massot <[email protected]>
julien-massot
pushed a commit
to julien-massot/debos
that referenced
this pull request
Feb 19, 2025
Will remove when go-debos/fakemachine#222 is done. Signed-off-by: Julien Massot <[email protected]>
|
@julien-massot can you post your test patch to this PR? |
@sjoerdsimons sure, it's posted. |
obbardc
requested changes
Feb 24, 2025
added 3 commits
February 24, 2025 13:39
The sector size is added at drive level, so it's correctly reported by the kernel, allowing userland software to works without overriding the values. UML backend doesn't support alternate sector size since the ubd driver hardcode the 512 bytes sector size. (arch/um/drivers/ubd_kern.c) Signed-off-by: Julien Massot <[email protected]>
We now support a SetSectorSize method, add a test for the two common values 512 and 4096. The test start a machine with a given sector size and verify that the block device correctly reports the physical and logical sizes. Skip 4k sector size test on UML backend since it's not supported. Signed-off-by: Julien Massot <[email protected]>
4k sector size testing is intentionnally skipped for the UML backend. Then it should not be considered as a ci failure. Signed-off-by: Julien Massot <[email protected]>
sjoerdsimons
approved these changes
Feb 24, 2025
julien-massot
pushed a commit
to julien-massot/debos
that referenced
this pull request
Feb 25, 2025
Will remove when go-debos/fakemachine#222 is done. Signed-off-by: Julien Massot <[email protected]>
julien-massot
pushed a commit
to julien-massot/debos
that referenced
this pull request
Feb 25, 2025
Will remove when go-debos/fakemachine#222 is done. Signed-off-by: Julien Massot <[email protected]>
obbardc
approved these changes
Feb 25, 2025
julien-massot
pushed a commit
to julien-massot/debos
that referenced
this pull request
Feb 26, 2025
Will remove when go-debos/fakemachine#222 is done. Signed-off-by: Julien Massot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sector size is added at drive level, so it's correctly reported by the kernel, allowing userland software to works without overriding the values. UML backend doesn't support alternate sector size since the ubd driver hardcode the 512 bytes sector size. (arch/um/drivers/ubd_kern.c)