Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): allow private struct fields to be set #3814

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

mvertes
Copy link
Contributor

@mvertes mvertes commented Feb 24, 2025

Go reflect doesn't allow to set unexported struct fields. We use unsafe to override this limitation.

Fixes #1155 and #3802

Go reflect doesn't allow to set unexported struct fields.
We use `unsafe` to override this limitation.

Fixes #1155 and #3812
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Feb 24, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 24, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ltzmaxwell ltzmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering the side effects, this approach seems appropriate cuz it's limited for the given situation: specifically for the gonative call scenario, is it?. so it looks good to me.
cc: @thehowl .

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal; with the removal of NativeValue/NativeType I want to get to having fmt.Printf in a native implementation that works on TypeValues (#1361) rather than with reflect. But this does the job for now, and solves a hiccup people have repeatedly; so let's merge this.

@thehowl thehowl merged commit a4b5c9c into master Feb 24, 2025
71 checks passed
@thehowl thehowl deleted the gno-fix-1155 branch February 24, 2025 13:51
@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

can't use unexported struct fields when converting using gno2go
5 participants