Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comondao): change commondao package to use addrset for members #3813

Conversation

jeronimoalbi
Copy link
Member

Changes CommonDAO members to use gno.land/p/moul/addrsetto store members.

This allows to use an address set for members which can optionally be stored in a separate realm if needed.

It also simplifies the commondao package code reducing the number of methods required to deal with member management.

This allows to use an address set for members which can optionally be
stored in a separate realm if needed.
@jeronimoalbi jeronimoalbi self-assigned this Feb 24, 2025
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Feb 24, 2025
@jeronimoalbi jeronimoalbi changed the title feat: change commondaopackage to use addrset for members feat(comondao): change commondao package to use addrset for members Feb 24, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 24, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@jeronimoalbi
Copy link
Member Author

@x1unix this PR is ready for review 🙏

Copy link
Contributor

@x1unix x1unix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jeronimoalbi jeronimoalbi merged commit ec9eacc into gnolang:devx/feature/commondao Feb 24, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants