Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add p/jeronimoalbi/pager package #3806

Merged
merged 10 commits into from
Feb 25, 2025
Merged

Conversation

jeronimoalbi
Copy link
Member

Package implements a way to support paging in generic cases that don't use an AVL trees.

@jeronimoalbi jeronimoalbi self-assigned this Feb 21, 2025
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Feb 21, 2025
@Gno2D2 Gno2D2 requested a review from a team February 21, 2025 17:45
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Feb 21, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 21, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@leohhhn
Copy link
Contributor

leohhhn commented Feb 24, 2025

Please check if we also handle gnoweb args properly, ie $help, $source

@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Feb 24, 2025
@moul
Copy link
Member

moul commented Feb 24, 2025

Related with #3414

(I'll make sure to link your implementation from mine)

@jeronimoalbi
Copy link
Member Author

Please check if we also handle gnoweb args properly, ie $help, $source

@leohhhn special Gnoweb args are filtered before the Render so they don't get to the render path, it can be tested using gno.land/r/demo/echo realm

@jeronimoalbi jeronimoalbi marked this pull request as draft February 25, 2025 11:25
@jeronimoalbi
Copy link
Member Author

Addressing comments 👍

@jeronimoalbi jeronimoalbi marked this pull request as ready for review February 25, 2025 14:07
@thehowl thehowl merged commit 6bf3889 into master Feb 25, 2025
63 checks passed
@thehowl thehowl deleted the dev/jeronimoalbi/pager branch February 25, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants