Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gnovm): remove unused Machine.MaxCycles #3744

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

mvertes
Copy link
Contributor

@mvertes mvertes commented Feb 13, 2025

The logic to manage the CPU limit is already handled by the gasmeter, which has the ability to panic the gnovm if a cpu limit is reached.

It's simpler and faster to have only one path of failure.

No other changes in CPU cycles accounting, still performed in gnovm.

The logic to manage the CPU limit is already handled by the gasmeter, which
has the ability to panic the gnovm if a cpu limit is reached.

It's simpler and faster to have only one path of failure.

No other changes in CPU cycles accounting, still performed in gnovm.
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Feb 13, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 13, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/machine.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thehowl thehowl merged commit e9e04ea into master Feb 13, 2025
61 of 62 checks passed
@thehowl thehowl deleted the gno-rm-maxcycles branch February 13, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

3 participants