Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some of the blog links in the gno naming page #3743

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pluto1011
Copy link

I made some updates on these two folders:

  • examples/gno.land/p/demo/users
  • examples/gno.land/r/demo/users

I added more features for the Gns users to add their blog posts, pictures, descriptions of their own, and posts(small set of paragraphs like social media). The users can update and decorate their own data like SNS.

I didn't made additional updates of the CSS and the tx-indexer which is currently being used in the gno page, but I will update it later.

The changed Render() return dataset shows like this:
스크린샷 2025-02-13 오후 4 54 03

And the currently expected page would show like this:
2025, 20_10_23 GMT+9

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Feb 13, 2025
@Gno2D2 Gno2D2 requested a review from a team February 13, 2025 07:57
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 13, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: pluto1011/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🟢 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@pluto1011
Copy link
Author

Notice: "examples/gno.land/r/demo/users" is not currently working because of the type Profile struct which should be imported from the "examples/gno.land/r/demo/users". I'm currently fixing on this.

@pluto1011 pluto1011 changed the title added some of the blog links in the gns page added some of the blog links in the gno naming page Feb 13, 2025
@leohhhn
Copy link
Contributor

leohhhn commented Feb 13, 2025

Hey, just a heads up; r/demo/users will soon be deprecated and removed completely, replaced by realms from #3166

Let me know if you guys need anything specific for Gnoswap or similar, and we'll figure it out.

For profile data, we'll use r/demo/profile, which will most likely be moved to r/nt/profiles or r/gnoland/profiles. The idea is to have this be the single, unique source of truth for "profiles".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

3 participants