fix(rpc): Update http batch request to handle singletons

[masonmcbride]

This pull request updates the HTTP batch request to handle singletons correctly.

Closes #3676

In sendRequestCommon, if the JSON response fails to unmarshal into the expected type, the function checks if the expected response type is a slice. If so, it attempts to unmarshal the JSON as a single element of that slice. When successful, it wraps the single element into a new slice and returns it, thereby gracefully handling cases where a singleton response is provided instead of an array.

[Gno2D2]

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

• IGNORE the bot requirements for this PR (force green CI check)
• The pull request description provides enough details (checked by @n2p5)

Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

1. Fix any issues flagged by automated checks.
2. Follow the Contributor Checklist to ensure your PR is ready for review.
   • Add new tests, or document why they are unnecessary.
   • Provide clear examples/screenshots, if necessary.
   • Update documentation, if required.
   • Ensure no breaking changes, or include BREAKING CHANGE notes.
   • Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

• Report a bug with the bot.
• View the bot’s configuration file.

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: masonmcbride/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

• Any user with comment edit permission

The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

• team core-contributors

[notJoon]

duplicated with #3678

[n2p5]

It looks like we've resolved this issue with the RPC server patch #3678 , but I still think it is worthwhile thinking about how we could make the client more forgiving as well. I'll pass long feedback line in a review.

[n2p5]

Nice first pass, please see my comments in line for a few changes.

[n2p5]

This should be expressed as a one-liner. I think nil should work, but if R needs various return types to be supported, you should be able to handle it by declaring the default value on the same line.

[n2p5]

Let's try to refactor this without reflection. Take notes from the RPC Server patch on how you could approach this. If the Slice marshalling fails, attempt to unmarshal a single response item and put that in a slice of the responses for the return.

[n2p5]

@notJoon I still think this is worth patching so that Batching responses for the client will work, even on older test nets. This follows the robustness principle (Postel's Law). If we can coax a slightly malformed response into a correct one, then it is better for the end-user experience. But, with the server patch, all testnets moving forward should be fine with the server side-only change.

[masonmcbride]

I updated both the server side (Omar's solution) and the client side (mine) functions associated with batch requests so that they have the same functionality but are more readable. On the server side, it tries to unmarshall into a slice of Responses and if it can't it tried to unmarshall into a single Response but both cases perform the same process which is abstracted out as processRequest. On the client side, sendRequestCommon has R ResponseType which is a *types.RPCResponse | types.RPCResponses so it uses a switch case on the return type and exhausts the cases for a clear program flow.