feat(examples/hof): Title and description for realms, sorting by upvotes and newest #3674

Ursulovic · 2025-02-03T13:06:09Z

Title And Description for Hall of Fame realms

Goal

Add title and description to realms in the Hall of Fame, as well as functionality of sorting realms by upvotes and by date of publishing.

Improvements

Title and Description

Realms in Hall of Fame will now have title and description, this will give users more context about each realm.
From now on, people who wish to publish their realm in the Hall of Fame will have to provide a title and description when registering their realm.

Sorting Realms by Upvotes and Newest realms

Realms in the Hall of Fame will now have the functionality to be sorted by upvotes and most recent realms. This will improve user experience by making it easier to find specific realms or explore new ones.

Feature Progress 🔄

Title and description functionality
Tests for title and description functionality
Sorting realms by upvotes and newest realms functionality
Tests for sorting realms by upvotes and newest realms functionality

Gno2D2 · 2025-02-03T13:07:49Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)
The pull request description provides enough details

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: Ursulovic/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])
Can be checked by

team core-contributors

codecov · 2025-02-03T17:24:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

leohhhn · 2025-02-04T11:20:35Z

examples/gno.land/r/leon/hof/hof.gno

+func RegisterMetadata(params ...string) Metadata {
+	// Validate params length
+	if len(params) != 2 {
+		panic(ErrInvalidMetadata)
+	}


This is a bad approach, you're using variadic arguments but you know that you will have only two arguments.

Variadic arguments should be used only in specific cases, and this isn't one of them, as you could've done this in a very straighforward manner with two arguments.

Removed variadic arguments and used 2 arguments instead: 02edc70

leohhhn · 2025-02-04T11:21:57Z

examples/gno.land/r/leon/hof/hof.gno

 	exhibition.items.Set(pkgpath, i)
 	exhibition.itemsSorted.Set(id.String(), i)

 	std.Emit("Registration")
 }

+func RegisterMetadata(params ...string) Metadata {


Remove this whole function; Just add the title and description in the Register function directly. Keep the checks, but don't panic but just add an empty return, just like in the rest of the function

Imagine how your code will be used; if you need to use Register inside of another realm's code, if you panic, you will fully block execution of the realm that called Register. If you simply do a return, without an error, in Register, HOF will try to add the realm that called it, it may work, but if not, nothing will happen.

Removed RegisterMEtadata functon, also replaced panic with return in this commit: 02edc70

leohhhn · 2025-02-04T11:22:36Z

examples/gno.land/r/leon/hof/hof.gno

 		upvote   *avl.Tree // std.Addr > struct{}{}
 		downvote *avl.Tree // std.Addr > struct{}{}
 	}
+
+	Metadata struct {


I don't see a reason to have this, just add two strings to the Item type

Done in commit: 02edc70

leohhhn · 2025-02-04T11:26:35Z

examples/gno.land/r/leon/hof/render.gno

@@ -45,7 +46,7 @@ func (e Exhibition) Render(path string, dashboard bool) string {

 		out += "<div>\n\n"
 		id, _ := seqid.FromString(item.Key)
-		out += ufmt.Sprintf("### Submission #%d\n\n", int(id))
+		out += md.H3(ufmt.Sprintf("Submission #%d", int(id))) + "\n"


Is a \n needed here? I'm not sure, please double check

I removed this in last commit, markdown is a lot different from this: 02edc70

leohhhn · 2025-02-04T11:27:04Z

examples/gno.land/r/leon/hof/render.gno

+	out := ""
+
+	out += md.CodeBlock(i.pkgpath) + "\n"


Can you add a screenshot of how the new hall of fame page will look like?

Lately I've changed the look of HoF alot, so I don't think this is relevant anymore, but here is screenshot of refactored look:

Since we didn't discuss the specifics of a new look, I took the liberty of designing it this way. Let me know if any changes are needed.

leohhhn

You need to change the approach in your implementation; I've left comments.

leohhhn

@Ursulovic

A couple of things, some of which are the fundamentals of collaborating on GitHub:

Please, when someone leaves comments, reply to them properly; ideally you also add the commit in which you fixed what the comment was about.
When you add new functionality somewhere, you also need to write tests to cover that. I tried using the app and clicking the "sort by upvotes", but it just doesn't work.
You need to update the PR title and description to match what's going on in the PR, which isn't the case right now.
When you finish your work on a PR, you need to check the CI, which will tell you if something is wrong (ie the tests fail currently)

Btw; you removed the sorting functionality that the app originally had (sort by latest) and replaced it with the "sort by upvotes". The default sort should be by time of addition, while the other option should be sort by upvotes (most and least). Also, you've changed the datasource impl, and I'm assuming that you didn't check out where it's used - I suggest you keep it the same as before, as someone might be depending on it.

You also made some other mistakes, but we'll get to them once the above is resolved.

This is all a learning process; it's ok that you make mistakes, but I would like to see you put in a bit more time, effort and focus into your work, and not do things last minute & rushed.

…red on HoF in order to match new Register function signature

…Markdown

…raw Markdown

…ber and description

…ts for datasource to match new fields, added tests in hof_test to test new cases

…for it

…ting sorting filter

…n for generating keys, other minor improvements

moul · 2025-02-11T14:42:59Z

examples/gno.land/r/leon/hof/datasource_test.gno

+		description: "This is a test realm in the Hall of Fame",
+		blockNum:    42,
+		upvote:      avl.NewTree(),
+		downvote:    avl.NewTree(),
 	}
 	item.downvote.Set("g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5", struct{}{})
 	item.upvote.Set("g1w4ek2u33ta047h6lta047h6lta047h6ldvdwpn", struct{}{})


btw @leohhhn; you can consider using p/moul/addrset to make this more efficiently.

@Ursulovic Let's switch to p/moul/addrset for managing the number of upvotes/downvotes

@leohhhn Will do!

Implemented in commit: c576d01

… avl trees

github-actions bot assigned Ursulovic Feb 3, 2025

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Feb 3, 2025

Ursulovic changed the title ~~Improvement(Hall of Fame): Title and Description for Realms~~ feat(Hall of Fame): Title and Description for Realms Feb 3, 2025

Gno2D2 requested a review from a team February 3, 2025 13:07

leohhhn changed the title ~~feat(Hall of Fame): Title and Description for Realms~~ feat(examples/hof): Title and description for realms Feb 3, 2025

Ursulovic marked this pull request as ready for review February 3, 2025 18:32

Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Feb 3, 2025

leohhhn reviewed Feb 4, 2025

View reviewed changes

leohhhn requested changes Feb 4, 2025

View reviewed changes

leohhhn requested changes Feb 7, 2025

View reviewed changes

Ursulovic changed the title ~~feat(examples/hof): Title and description for realms~~ feat(examples/hof): Title and description for realms, sorting by upvotes and newest Feb 9, 2025

Ursulovic closed this Feb 9, 2025

Ursulovic force-pushed the hof-imporvement-1 branch from b55f906 to 262e8ff Compare February 9, 2025 11:56

Ivan Ursulovic added 8 commits February 9, 2025 13:08

Added functionality of registering for hof.gno

eba14bc

Added title and description of my own choosing for each realm registe…

83ea641

…red on HoF in order to match new Register function signature

Updated render.gno to use md.gno library for Markdown instead of raw …

d6cfe3b

…Markdown

Updated datasoruce.gno to use md.gno package for Markdown instead of …

6b13b08

…raw Markdown

Replaced remaining raw Markdown formatting with md.gno.

f695fa0

Ran make fmt and make tidy

cad1078

Changed render.gno so now it displays title instead of submission num…

a39de4b

…ber and description

Ran make fmt and make tidy

02edc70

Ursulovic reopened this Feb 9, 2025

Ivan Ursulovic and others added 2 commits February 10, 2025 01:53

Updated datasource to have new fields in updated hof.gno, changed tes…

a4930f9

…ts for datasource to match new fields, added tests in hof_test to test new cases

Merge branch 'gnolang:master' into hof-imporvement-1

c8c08c1

Ivan Ursulovic and others added 11 commits February 10, 2025 15:45

Minor updates to Conent() and test

79962ee

Implemented func for generating key for sorting by upvotes and tests …

9b77d54

…for it

Make fmt, make tidy

a528f04

Merge branch 'gnolang:master' into hof-imporvement-1

9c36253

Fixed some logic in hof, started writting tests

f63926a

Make fmt, make tidy

2c2937b

Added buttons for sorting in render

0a94cf6

Added functionality for sorting realms by upvotes and button for rese…

a6c0271

…ting sorting filter

Make fmt, make tidy

30eb70b

Implemented logic for sorting realms by downvotes in hof.gno

795a666

Fixed bugs in logic for sorting realms by downvotes, improved functio…

e035518

…n for generating keys, other minor improvements

moul reviewed Feb 11, 2025

View reviewed changes

Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Feb 11, 2025

Ursulovic and others added 7 commits February 11, 2025 16:09

Merge branch 'gnolang:master' into hof-imporvement-1

84ebebd

Added logic for sorting realms by creation time in hof

b98a676

Added logic for sorting by creation time in render

0dc0b0c

Fixed naming in tests

edd2695

Upvotes and downvotes are now tracker using p/moul/addrset instead of…

a9e7719

… avl trees

Fixed tests to use adrrset instead of avl trees

53b056c

Make fmt, make tidy

c576d01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(examples/hof): Title and description for realms, sorting by upvotes and newest #3674

feat(examples/hof): Title and description for realms, sorting by upvotes and newest #3674

Ursulovic commented Feb 3, 2025 •

edited

Loading

Gno2D2 commented Feb 3, 2025 •

edited

Loading

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

If

Can be checked by

codecov bot commented Feb 3, 2025

leohhhn Feb 4, 2025 •

edited

Loading

Ursulovic Feb 9, 2025

leohhhn Feb 4, 2025

leohhhn Feb 4, 2025

Ursulovic Feb 9, 2025

leohhhn Feb 4, 2025

Ursulovic Feb 9, 2025

leohhhn Feb 4, 2025

Ursulovic Feb 9, 2025

leohhhn Feb 4, 2025

Ursulovic Feb 9, 2025

leohhhn left a comment

leohhhn left a comment •

edited

Loading

moul Feb 11, 2025

leohhhn Feb 11, 2025

Ursulovic Feb 11, 2025

Ursulovic Feb 11, 2025

feat(examples/hof): Title and description for realms, sorting by upvotes and newest #3674

Are you sure you want to change the base?

feat(examples/hof): Title and description for realms, sorting by upvotes and newest #3674

Conversation

Ursulovic commented Feb 3, 2025 • edited Loading

Title And Description for Hall of Fame realms

Goal

Improvements

Title and Description

Sorting Realms by Upvotes and Newest realms

Feature Progress 🔄

Gno2D2 commented Feb 3, 2025 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

If

Can be checked by

codecov bot commented Feb 3, 2025

Codecov Report

leohhhn Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leohhhn left a comment

Choose a reason for hiding this comment

leohhhn left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ursulovic commented Feb 3, 2025 •

edited

Loading

Gno2D2 commented Feb 3, 2025 •

edited

Loading

leohhhn Feb 4, 2025 •

edited

Loading

leohhhn left a comment •

edited

Loading