fix: catch infite loops without condition and body

[petar-dambovaliev]

closes 3612

[Gno2D2]

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

• IGNORE the bot requirements for this PR (force green CI check)

Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:

1. Fix any issues flagged by automated checks.
2. Follow the Contributor Checklist to ensure your PR is ready for review.
   • Add new tests, or document why they are unnecessary.
   • Provide clear examples/screenshots, if necessary.
   • Update documentation, if required.
   • Ensure no breaking changes, or include BREAKING CHANGE notes.
   • Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

• Report a bug with the bot.
• View the bot’s configuration file.

Debug

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

• Any user with comment edit permission

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gnovm/pkg/gnolang/transcribe.go	33.33%	1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[odeke-em]

Thanks for the fix @petar-dambovaliev! However, this PR doesn't fix the actual issue which is ensuring that the gas metering actually runs out, unless I am missing something?

[thehowl]

we shouldn't reject infinite loops at the language level. if somebody wants to shoot themselves in the foot when using gno run, they should be able to do so. our gas system should catch this and prevent this on-chain.

[petar-dambovaliev]

@thehowl @odeke-em this targeted the special case, catching it during preprocessing since this specific case can't represent a useful gno program. I mentioned this during a core team meeting and no one objected so it might be better to ask other people to give their opinion too before closing it.

[thehowl]

Apologies this seemed like a random close; my intent in closing PRs this way is that the approach needs a complete re-visit, and I see issues as a better venue for discussion in cases like these rather than PRs, which should be for work that is potentially imperfect, but in the right direction.

[petar-dambovaliev]

Apologies this seemed like a random close; my intent in closing PRs this way is that the approach needs a complete re-visit, and I see issues as a better venue for discussion in cases like these rather than PRs, which should be for work that is potentially imperfect, but in the right direction.

Agreed. In Any case, this is orthogonal to tweeks in the gas system.