Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(boards2): add missing filetests for board rename #3625

Conversation

jeronimoalbi
Copy link
Member

@jeronimoalbi jeronimoalbi commented Jan 28, 2025

Add a missing filetests for RenameBoard() function.

Related to #3623.

This covers all tests for the function:

  • Rename success by default board owner
  • Fail w/ empty board name
  • Fail w/ existing board name
  • Fail when renaming unexisting board
  • Fail w/ an address as board name
  • Rename success by another board owner
  • Fail because name is registered and not owned in users realm
  • Fail w/ short name
  • Rename success with owned name registered in users realm
  • Fail for non board DAO member

@jeronimoalbi jeronimoalbi self-assigned this Jan 28, 2025
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jan 28, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 28, 2025

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check) (checked by @jeronimoalbi)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: gnostudio/gno)

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@jeronimoalbi jeronimoalbi marked this pull request as ready for review January 28, 2025 16:23
@jeronimoalbi
Copy link
Member Author

@x1unix this PR is ready for review 🙏

@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 28, 2025
@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 28, 2025
@jeronimoalbi jeronimoalbi merged commit 33fb889 into gnolang:devx/feature/boardsv2 Jan 28, 2025
68 checks passed
@jeronimoalbi jeronimoalbi deleted the test/filetests-rename-board branch January 29, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants