Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(benchops): support 32-bit compilation #3373

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(benchops): support 32-bit compilation #3373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gnovm/pkg/benchops/exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
// byte 2: StoreCode
// byte 3-6: Duration
// byte 7-10: Size
func (e *exporter) export(code Code, elapsedTime time.Duration, size int) {
func (e *exporter) export(code Code, elapsedTime time.Duration, size int64) {

Check warning on line 36 in gnovm/pkg/benchops/exporter.go

View check run for this annotation

Codecov / codecov/patch

gnovm/pkg/benchops/exporter.go#L36 

Added line #L36 was not covered by tests
// the MaxUint32 is 4294967295. It represents 4.29 seconds in duration or 4G bytes.
// It panics not only for overflow protection, but also for abnormal measurements.
if elapsedTime > math.MaxUint32 {
Expand Down Expand Up @@ -74,7 +74,7 @@
fileWriter.export(
code,
measure.storeAccumDur[i]/time.Duration(count),
int(measure.storeAccumSize[i]/count),
measure.storeAccumSize[i]/count,

Check warning on line 77 in gnovm/pkg/benchops/exporter.go

View check run for this annotation

Codecov / codecov/patch

gnovm/pkg/benchops/exporter.go#L77 

Added line #L77 was not covered by tests
)
}
}
Expand Down
Loading