Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve devx boards2 branch issues #3365

Merged
merged 2 commits into from
Dec 18, 2024
+6 −24
Merged

fix: resolve devx boards2 branch issues #3365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64be845
fix: remove require from gno mod files
jeronimoalbi Dec 18, 2024
eff7e0b
fix: use `txlink` package's Call fucntion instead of URL
jeronimoalbi Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions examples/gno.land/p/demo/boards2/admindao/gno.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1 @@
module gno.land/p/demo/boards2/admindao

require (
gno.land/p/demo/avl v0.0.0-latest
gno.land/p/demo/uassert v0.0.0-latest
gno.land/p/demo/urequire v0.0.0-latest
)
2 changes: 1 addition & 1 deletion examples/gno.land/r/demo/boards2/board.gno
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,5 +114,5 @@ func (board *Board) GetURLFromReplyID(threadID, replyID PostID) string {
}

func (board *Board) GetPostFormURL() string {
return txlink.URL("CreateThread", "bid", board.id.String())
return txlink.Call("CreateThread", "bid", board.id.String())
}
2 changes: 1 addition & 1 deletion examples/gno.land/r/demo/boards2/board_test.gno
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func TestBoard_GetURLFromReplyID(t *testing.T) {
func TestBoard_GetPostFormURL(t *testing.T) {
bid := BoardID(386)
b := newBoard(bid, "foo1234", "")
expect := txlink.URL("CreateThread", "bid", bid.String())
expect := txlink.Call("CreateThread", "bid", bid.String())
got := b.GetPostFormURL()
uassert.Equal(t, expect, got)
}
12 changes: 0 additions & 12 deletions examples/gno.land/r/demo/boards2/gno.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1 @@
module gno.land/r/demo/boards2

require (
gno.land/p/demo/avl v0.0.0-latest
gno.land/p/demo/boards2/admindao v0.0.0-latest
gno.land/p/demo/mux v0.0.0-latest
gno.land/p/demo/testutils v0.0.0-latest
gno.land/p/demo/uassert v0.0.0-latest
gno.land/p/demo/ufmt v0.0.0-latest
gno.land/p/demo/urequire v0.0.0-latest
gno.land/p/moul/txlink v0.0.0-latest
gno.land/r/demo/users v0.0.0-latest
)
8 changes: 4 additions & 4 deletions examples/gno.land/r/demo/boards2/post.gno
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,28 +180,28 @@ func (post *Post) GetURL() string {
}

func (post *Post) GetReplyFormURL() string {
return txlink.URL("CreateReply",
return txlink.Call("CreateReply",
"bid", post.board.id.String(),
"threadID", post.threadID.String(),
"postID", post.id.String(),
)
}

func (post *Post) GetRepostFormURL() string {
return txlink.URL("CreateRepost",
return txlink.Call("CreateRepost",
"bid", post.board.id.String(),
"postID", post.id.String(),
)
}

func (post *Post) GetDeleteFormURL() string {
if post.IsThread() {
return txlink.URL("DeleteThread",
return txlink.Call("DeleteThread",
"bid", post.board.id.String(),
"threadID", post.threadID.String(),
)
}
return txlink.URL("DeleteReply",
return txlink.Call("DeleteReply",
"bid", post.board.id.String(),
"threadID", post.threadID.String(),
"replyID", post.id.String(),
Expand Down
Loading