Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): teritori's dao sdk #3358

Draft
wants to merge 120 commits into
base: master
Choose a base branch
from
Draft

Conversation

n0izn0iz
Copy link
Contributor

@n0izn0iz n0izn0iz commented Dec 17, 2024

This implement a DAO SDK inspired by DA0-DA0

Continuation of #1925 in a branch that allows maintainers edits and has a sane base.

Last status on the previous PR was a message by @moul stating

Can you move all the packages under {r,p}/teritori/... and relocate the docs/... into r/teritori/dao_maker/README.md?

I believe we should merge your PR in its current state but under teritori.

We have iterated on this in our repo and it might lack a lot of features and bug fixes, we wonder if we should update or merge as-is.

It includes:

  • Interfaces for the DAO gno.land/p/demo/dao_maker/dao_interfaces
  • A reference implementation for the core of the DAO gno.land/p/demo/dao_maker/dao_core
  • A membership-based voting module gno.land/p/demo/dao_maker/dao_voting_group
  • A single-choice proposal module gno.land/p/demo/dao_maker/dao_proposal_single
  • An example DAO gno.land/r/demo/dao_maker/dao_realm
  • A registry to dynamically interact with any registered DAO using it's address gno.land/r/demo/dao_maker/dao_registry

For usage see the tutorial

Screenshot 2024-04-12 at 18 41 10

There is an example membership-based DAO at gno.land/r/teritori/dao_realm that can administer itself and a grc20 token at gno.land/r/teritori/tori

Here is it's GnoWeb Render:
Screenshot 2024-04-12 at 18 28 41


This powers the "Organizations" feature of Teritori dApp on Gno as shown below

The DAO creation UI uses a Gno template and instantiates a new realm.

Screenshot 2024-04-12 at 18 43 23 Screenshot 2024-04-12 at 18 44 50 Screenshot 2024-04-12 at 18 44 15 Screenshot 2024-04-12 at 18 42 26
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Norman Meier added 30 commits April 10, 2024 19:11
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
n0izn0iz and others added 22 commits May 4, 2024 11:27
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 17, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 17, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: n0izn0iz/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@n0izn0iz n0izn0iz mentioned this pull request Dec 17, 2024
7 tasks
Signed-off-by: Norman Meier <[email protected]>
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@thehowl
Copy link
Member

thehowl commented Dec 18, 2024

What is still pending on this PR? Just the CI?

@n0izn0iz
Copy link
Contributor Author

well, that, and it's outdated code, I wonder if we should update this with the latest version we have in our monorepo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

5 participants