-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : grc dir examples and minor improvements #3353
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
9353eb5
to
273fb27
Compare
) | ||
|
||
// ExampleInit demonstrates how to initialize a new token. | ||
func ExampleInit() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to have those Example
tests. However, since they are not yet supported, I believe we should avoid using them because the tests are not actually tested.
We can keep your PR on hold until we have the feature. Alternatively, you could comment out everything and add a note explaining that it is just for inspiration, not a real test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention was to showcase how to use the token lib as I have had some troubles in the past with using banker as there was a lack of examples, but you are right I will address this in a comment
@@ -1,3 +0,0 @@ | |||
package grc20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone see an interesting mock for GRC20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was extra, adding it to the todo list🫡
After thinking about it for a while I have decided to put this PR on hold as @moul suggested, or even close it until |
Suggestion: maybe we can make these into filetests for now before we have testable examples. |
I have no experience with that, but if you could maybe point me to some examples I'm confident I'll figure it out |
Work in progress
Description
This PR serves a u puropse of adding little missing details in the GRC directory to try and make it's use a little bit easier, for instance adding functions to examples_test.gno. I will also try to fill some holes if there is room for improvement, like add safety checks, etc.
Contributors checklist
Any thoughts and advice is welcome