Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/gno): re-use teststore in lint #3315

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Dec 10, 2024

continuing the work of #3119.

this PR makes gno lint re-use the same test.Store, speeding up execution (especially on the CI, which lints all packages) by not needing to load all packages for each package that is linted.

@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Dec 10, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 10, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 74.72527% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/cmd/gno/lint.go 72.41% 6 Missing and 2 partials ⚠️
gnovm/pkg/gnomod/pkg.go 30.00% 5 Missing and 2 partials ⚠️
gnovm/pkg/packages/imports.go 81.81% 4 Missing ⚠️
gnovm/pkg/doc/dirs.go 57.14% 3 Missing ⚠️
gnovm/pkg/test/filetest.go 88.88% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my machine, linting the entire example folder, I went from 2m20s to 8s ... 🚀 🤩

cc @zivkovicmilos

@gfanton gfanton merged commit d69b552 into gnolang:master Dec 18, 2024
110 checks passed
albttx pushed a commit that referenced this pull request Jan 10, 2025
continuing the work of #3119.

this PR makes `gno lint` re-use the same test.Store, speeding up
execution (especially on the CI, which lints all packages) by not
needing to load all packages for each package that is linted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

4 participants