Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: import gnolang/overflow into gno/tm2/pkg/overflow #3302

Merged
merged 6 commits into from
Dec 8, 2024

Conversation

mvertes
Copy link
Contributor

@mvertes mvertes commented Dec 8, 2024

We remove the dependency on gnolang/overflow, a clone of https://github.com/JohnCGriffin/overflow which is now unmaintained, and import it into gno/tm2/pkg/overflow. We can now have full control on it, fix it and improve it.

This PR just changes the import path, no content change is done yet.

We remove the dependency on gnolang/overflow, a clone of
https://github.com/JohnCGriffin/overflow which is now unmaintained
and import it into gno/tm2/pkg/overflow. We can now have full
control on it, fix it and improve it.

This PR just changes the import path, no content change is done yet.
@mvertes mvertes marked this pull request as ready for review December 8, 2024 16:57
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related labels Dec 8, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 8, 2024

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🟢 Maintainers must be able to edit this pull request (more info)
🟢 The pull request head branch must be up-to-date with its base (more info)

Manual Checks

No manual checks match this pull request.

Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Head branch (mvertes:gno-tm2-overflow) is up to date with base (master): behind by 0 / ahead by 6

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 15.41353% with 225 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tm2/pkg/overflow/overflow_impl.go 15.86% 174 Missing and 1 partial ⚠️
tm2/pkg/overflow/overflow.go 13.79% 50 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gofumpt'ed to make our CI pass, but the contents are the same as current repo. approving.

@thehowl thehowl merged commit 666c54a into gnolang:master Dec 8, 2024
103 of 105 checks passed
@mvertes mvertes deleted the gno-tm2-overflow branch December 8, 2024 22:02
Villaquiranm pushed a commit to Villaquiranm/gno that referenced this pull request Dec 9, 2024
We remove the dependency on gnolang/overflow, a clone of
https://github.com/JohnCGriffin/overflow which is now unmaintained, and
import it into gno/tm2/pkg/overflow. We can now have full control on it,
fix it and improve it.

This PR just changes the import path, no content change is done yet.

---------

Co-authored-by: Morgan Bazalgette <[email protected]>
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
We remove the dependency on gnolang/overflow, a clone of
https://github.com/JohnCGriffin/overflow which is now unmaintained, and
import it into gno/tm2/pkg/overflow. We can now have full control on it,
fix it and improve it.

This PR just changes the import path, no content change is done yet.

---------

Co-authored-by: Morgan Bazalgette <[email protected]>
albttx pushed a commit that referenced this pull request Jan 10, 2025
We remove the dependency on gnolang/overflow, a clone of
https://github.com/JohnCGriffin/overflow which is now unmaintained, and
import it into gno/tm2/pkg/overflow. We can now have full control on it,
fix it and improve it.

This PR just changes the import path, no content change is done yet.

---------

Co-authored-by: Morgan Bazalgette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

3 participants