Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gnovm): use strconv.UnquoteChar to parse rune literals #3296

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix(gnovm): use strconv.UnquoteChar to parse rune literals #3296

merged 1 commit into from
Dec 9, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Dec 8, 2024

This fixes a bug, as shown in rune3.gno, whereby rune literals which would not be parsed correctly by strconv.Unquote are now parsed correctly. Previously, the test would print out 65533, for the unicode invalid code point.

@thehowl thehowl requested review from mvertes and ltzmaxwell December 8, 2024 10:34
@thehowl thehowl self-assigned this Dec 8, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Dec 8, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 8, 2024 •
edited
Loading

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🟢 Maintainers must be able to edit this pull request (more info)
🟢 The pull request head branch must be up-to-date with its base (more info)

Manual Checks

No manual checks match this pull request.

Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Head branch (thehowl:dev/morgan/no-strconv-unquote) is up to date with base (master): behind by 0 / ahead by 1

@codecov Codecov
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@thehowl thehowl added this to the 🚀 Mainnet launch milestone Dec 8, 2024
@thehowl thehowl added the 🐞 bug Something isn't working label Dec 8, 2024
@thehowl thehowl mentioned this pull request Dec 8, 2024
Merged
4 tasks
@thehowl thehowl changed the title fix(gnolang): use strconv.UnquoteChar to parse rune literals fix(gnovm): use strconv.UnquoteChar to parse rune literals Dec 8, 2024
mvertes
mvertes approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@thehowl thehowl merged commit 5f16b8c into gnolang:master Dec 9, 2024
110 checks passed
Villaquiranm pushed a commit to Villaquiranm/gno that referenced this pull request Dec 9, 2024
@thehowl @Villaquiranm
fix(gnovm): use strconv.UnquoteChar to parse rune literals (gnolang#3296
f417e7f 
)

This fixes a bug, as shown in rune3.gno, whereby rune literals which
would not be parsed correctly by `strconv.Unquote` are now parsed
correctly. Previously, the test would print out 65533, for the unicode
invalid code point.
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
@thehowl @r3v4s
fix(gnovm): use strconv.UnquoteChar to parse rune literals (gnolang#3296
ab305fe 
)

This fixes a bug, as shown in rune3.gno, whereby rune literals which
would not be parsed correctly by `strconv.Unquote` are now parsed
correctly. Previously, the test would print out 65533, for the unicode
invalid code point.
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
@thehowl @r3v4s
fix(gnovm): use strconv.UnquoteChar to parse rune literals (gnolang#3296
8da4886 
)

This fixes a bug, as shown in rune3.gno, whereby rune literals which
would not be parsed correctly by `strconv.Unquote` are now parsed
correctly. Previously, the test would print out 65533, for the unicode
invalid code point.
ltzmaxwell added a commit that referenced this pull request Dec 25, 2024
@notJoon @thehowl @ltzmaxwell
feat(stdlibs): add encoding, encoding/{base32,binary,csv} (#1290)
ea32315 
- [X] `encoding`
- [X] `encoding/base32`
- [X] `encoding/binary`
- [X] `encoding/csv` : Due to the `reflect` does not implemented yet,
skipped `fuzz`
---
1. `encoding/asn1`: better after `reflection`

related to:
 - gnoswap-labs#7
 - #1267

depends-on:

- #3296 
- #3298

---------

Co-authored-by: Morgan Bazalgette <[email protected]>
Co-authored-by: ltzmaxwell <[email protected]>
moul pushed a commit to moul/gno that referenced this pull request Dec 27, 2024
@notJoon @thehowl
@ltzmaxwell @moul
feat(stdlibs): add encoding, encoding/{base32,binary,csv} (gnolan…
95b429a 
…g#1290)

- [X] `encoding`
- [X] `encoding/base32`
- [X] `encoding/binary`
- [X] `encoding/csv` : Due to the `reflect` does not implemented yet,
skipped `fuzz`
---
1. `encoding/asn1`: better after `reflection`

related to:
 - gnoswap-labs#7
 - gnolang#1267

depends-on:

- gnolang#3296 
- gnolang#3298

---------

Co-authored-by: Morgan Bazalgette <[email protected]>
Co-authored-by: ltzmaxwell <[email protected]>
albttx pushed a commit that referenced this pull request Jan 10, 2025
@thehowl @albttx
fix(gnovm): use strconv.UnquoteChar to parse rune literals (#3296)
7fb7fd8 
This fixes a bug, as shown in rune3.gno, whereby rune literals which
would not be parsed correctly by `strconv.Unquote` are now parsed
correctly. Previously, the test would print out 65533, for the unicode
invalid code point.
albttx pushed a commit that referenced this pull request Jan 10, 2025
@notJoon @thehowl
@ltzmaxwell @albttx
feat(stdlibs): add encoding, encoding/{base32,binary,csv} (#1290)
7d9071a 
- [X] `encoding`
- [X] `encoding/base32`
- [X] `encoding/binary`
- [X] `encoding/csv` : Due to the `reflect` does not implemented yet,
skipped `fuzz`
---
1. `encoding/asn1`: better after `reflection`

related to:
 - gnoswap-labs#7
 - #1267

depends-on:

- #3296 
- #3298

---------

Co-authored-by: Morgan Bazalgette <[email protected]>
Co-authored-by: ltzmaxwell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

@mvertes mvertes mvertes approved these changes

@ltzmaxwell ltzmaxwell Awaiting requested review from ltzmaxwell

Assignees

@thehowl thehowl

Labels
🐞 bug Something isn't working 📦 🤖 gnovm Issues or PRs gnovm related
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
🚀 Mainnet beta launch
Development

Successfully merging this pull request may close these issues.
4 participants
@thehowl @Gno2D2 @moul @mvertes