-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: new txtar test for non-regression #2343
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2343 +/- ##
=======================================
Coverage 54.71% 54.71%
=======================================
Files 590 590
Lines 79036 79023 -13
=======================================
- Hits 43243 43237 -6
+ Misses 32543 32536 -7
Partials 3250 3250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We have this issue as well to do part of this #2253 |
The way this can be done in filetests, is by adding the I think it makes sense to put it there, as it's testing GnoVM behaviour with imports, not gno.land behaviour. |
This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months. |
I don't think we need to merge this pull request, but I wanted to open it to check a few points:
txtar
files. Is there a current contributing guideline explaining when to use one folder over another?txtar
, or is there a better approach?