Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typed-nil handling #1891

Merged
merged 139 commits into from
Feb 18, 2025
Merged

Conversation

ltzmaxwell
Copy link
Contributor

@ltzmaxwell ltzmaxwell commented Apr 4, 2024

update: ready for review.

====================================
the dependency relationship: #1890 <- this one.

Copy link

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

@github-actions github-actions bot added the Stale label Nov 20, 2024
@ltzmaxwell
Copy link
Contributor Author

on this.

@github-actions github-actions bot removed the Stale label Nov 21, 2024
@ltzmaxwell ltzmaxwell requested review from petar-dambovaliev and removed request for jaekwon, moul, thehowl and piux2 February 17, 2025 14:21
@ltzmaxwell ltzmaxwell changed the title fix: correct typed-nil handling fix (gnovm): correct typed-nil handling Feb 17, 2025
@ltzmaxwell ltzmaxwell marked this pull request as ready for review February 17, 2025 14:24
@ltzmaxwell ltzmaxwell requested a review from mvertes as a code owner February 17, 2025 14:24
@ltzmaxwell ltzmaxwell changed the title fix (gnovm): correct typed-nil handling fix: correct typed-nil handling Feb 17, 2025
Copy link
Contributor

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Please also consider fixing the lint issues by renaming max to maximum at places indicated by GitHub check annotations. Thanks.

@thehowl thehowl changed the base branch from fix/maxwell/type_comparison to master February 18, 2025 17:41
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 18, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: ltzmaxwell/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@thehowl thehowl added this to the 🚀 Mainnet beta launch milestone Feb 18, 2025
@thehowl thehowl merged commit 64ea826 into gnolang:master Feb 18, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants