Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sysobject.ids #36

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Update sysobject.ids #36

merged 2 commits into from
Sep 17, 2024

Conversation

jozephbrasil
Copy link

Added Intelbras Brand
Added Intelbras Gigabit Ethernet Switch Model SG2404MRL2

@jozephbrasil
Update sysobject.ids
8916ef5 
Added Intelbras Brand
Added Intelbras Gigabit Ethernet Switch Model SG2404MRL2
g-bougard
g-bougard requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@g-bougard g-bougard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jozephbrasil

thank you for your submission.

But there's an issue: you're using spaces as field separator where tabulation field separator must be used.

@jozephbrasil
Update sysobject.ids
a9e3bfc 
Tabulation issue fixed
jozephbrasil
jozephbrasil commented Sep 17, 2024
View reviewed changes
Copy link
Author

@jozephbrasil jozephbrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised tabulation

@g-bougard g-bougard merged commit 505c366 into glpi-project:master Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-bougard g-bougard g-bougard requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jozephbrasil @g-bougard