Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacity to add new itemtypes on schema #143

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

trasher
Copy link
Collaborator

@trasher trasher commented Sep 11, 2024

No description provided.

@trasher
Copy link
Collaborator Author

trasher commented Sep 11, 2024

To be reviewed per commit.
If someone has an idea to prevent latest commit (phpstan complains about missing index 1 in result, but that cannot happen), I'll take it.

@stonebuzz
Copy link
Collaborator

IMHO

you can't assume that index 1 exists and access it directly.

you need another isset (like you did) or array_key_exists

or null coalecing operators

$known_itemtypes = explode('|', $known_itemtypes[1] ?? '');

@trasher
Copy link
Collaborator Author

trasher commented Sep 11, 2024

Keeping isset() is fine, it's useless but it does not hurts :)

@trasher trasher merged commit 6cefd6a into master Sep 11, 2024
10 checks passed
@trasher trasher deleted the feature/extraitemtypes branch September 11, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants