Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): name with quotes #18797

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(dashboard): name with quotes #18797

merged 1 commit into from
Jan 23, 2025

Conversation

Rom1-B
Copy link
Contributor

@Rom1-B Rom1-B commented Jan 23, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !36055
  • Here is a brief description of what this PR does

A single quotation mark in the name truncated it in the edit field

Screenshots (if appropriate):

Before:

image

After:

image

@cedric-anne cedric-anne added this to the 10.0.18 milestone Jan 23, 2025
@trasher trasher merged commit 439857c into glpi-project:10.0/bugfixes Jan 23, 2025
8 checks passed
@Rom1-B Rom1-B deleted the support_36055 branch January 23, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne approved these changes

@trasher trasher trasher approved these changes

@AdrienClairembault AdrienClairembault Awaiting requested review from AdrienClairembault

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
10.0.18
Development

Successfully merging this pull request may close these issues.
3 participants
@Rom1-B @trasher @cedric-anne