Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more capacity descriptions #18791

Merged
merged 6 commits into from
Jan 29, 2025
Merged

add more capacity descriptions #18791

merged 6 commits into from
Jan 29, 2025

Conversation

orthagh
Copy link
Contributor

@orthagh orthagh commented Jan 22, 2025 •
edited
Loading

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.

Description

Add a description for each capacity.
I tried to add context hints for each. Some are more difficult than others.

Screenshots:

image

@orthagh orthagh modified the milestone: 11.0.0 Jan 27, 2025
@orthagh orthagh marked this pull request as ready for review January 27, 2025 09:32
cconard96
cconard96 suggested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@cconard96 cconard96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all the descriptions, maybe changing "this asset" to "these assets" since the description is done for the entire asset definition and functionalities affect the individual assets of that definition.

src/Glpi/Asset/Capacity/HasAntivirusCapacity.php Outdated Show resolved Hide resolved
src/Glpi/Asset/Capacity/HasAppliancesCapacity.php Outdated Show resolved Hide resolved
src/Glpi/Asset/Capacity/HasDevicesCapacity.php Outdated Show resolved Hide resolved
src/Glpi/Asset/Capacity/HasInfocomCapacity.php Outdated Show resolved Hide resolved
src/Glpi/Asset/Capacity/HasLinksCapacity.php Outdated Show resolved Hide resolved
src/Glpi/Asset/Capacity/IsReservableCapacity.php Outdated Show resolved Hide resolved
orthagh and others added 2 commits January 29, 2025 09:38
@orthagh @trasher @cconard96
Apply suggestions from code review
0b08a67 
Co-authored-by: Johan Cwiklinski <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
@orthagh
assets plural
27ce102
@orthagh orthagh requested review from cconard96 and trasher January 29, 2025 09:27
@cedric-anne cedric-anne merged commit e546c25 into glpi-project:main Jan 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne approved these changes

@cconard96 cconard96 cconard96 approved these changes

@trasher trasher trasher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orthagh @trasher @cconard96 @cedric-anne