Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cache tests test: Update test launch script and PHP attribute in cache tests #18716

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

SebSept
Copy link
Contributor

@SebSept SebSept commented Jan 13, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
  • Here is a brief description of what this PR does

Screenshots (if appropriate):

@trasher
Copy link
Contributor

trasher commented Jan 13, 2025

Seems I missed that in conversion; but it should be migrated to phpunit, not removed. Main point is the cache:configure options.

@trasher
Copy link
Contributor

trasher commented Jan 13, 2025

Also, this should be done on 10.0/bugfixes branch I guess.

@cedric-anne
Copy link
Member

Seems I missed that in conversion; but it should be migrated to phpunit, not removed. Main point is the cache:configure options.

It corresponds to @tags cache occurrences in thd PHP Units tests. The command should indeed be fixed to run them with each available test adapter.

@cedric-anne cedric-anne marked this pull request as draft January 14, 2025 09:03
@SebSept SebSept force-pushed the remove-empty-test-set branch 3 times, most recently from db6a8da to 92d955e Compare January 14, 2025 10:06
@SebSept SebSept force-pushed the remove-empty-test-set branch from 92d955e to 130f330 Compare January 14, 2025 10:08
@SebSept SebSept changed the title removed "cache tests" : no more atoum tests tagged cache fix cache tests test: Update test launch script and PHP attribute in cache tests Jan 14, 2025
.github/actions/test_tests-cache.sh Outdated Show resolved Hide resolved
@trasher
Copy link
Contributor

trasher commented Jan 14, 2025

Seems OK, but another PR must be done on 10.0/bugfixes branch.

@trasher trasher marked this pull request as ready for review January 14, 2025 13:08
@cedric-anne cedric-anne merged commit 4b9fbae into glpi-project:main Jan 14, 2025
9 checks passed
@trasher trasher mentioned this pull request Jan 14, 2025
@SebSept SebSept deleted the remove-empty-test-set branch January 27, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants