Cleanup error handler calls for future migration #18696
Draft
+1,095
−1,256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierstoval
force-pushed
the
error-handler
branch
4 times, most recently
from
2b4b38b to
d9b0e80
Compare
Pierstoval
force-pushed
the
error-handler
branch
from
d9b0e80 to
9ce9620
Compare
trasher
reviewed
Jan 13, 2025
ajax/dashboard.php
Outdated
Comment on lines
212
to
213
| ErrorHandler::getInstance()->handleException($e, true); | ||
| ErrorUtils::logException($e); | ||
| ErrorUtils::outputExceptionMessage($e); |
There was a problem hiding this comment.
It seems there are multiple places where a single line is replaced with 2 new ones. That's not really easy to understand and may be confusing.
Also, many things have changed regarding errro management, maybe a £ explaining how we should handle them correctly in the developper documentation would be a good thing.
There was a problem hiding this comment.
This double call is going to change. PR is still a draft.
I agree that the documentation should be update, I will take care of this once this PR will be finished.
Pierstoval
force-pushed
the
error-handler
branch
from
9ce9620 to
ab5a171
Compare
Pierstoval
force-pushed
the
error-handler
branch
from
e03b7d3 to
9f4fdb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final goal would be to leave error handling entirely to Symfony, and convert all existing "error handling" code in GLPI to either exceptions OR to
trigger_errorcalls.This first cleanup is here to standardize this with the 4 current identified cases (error or exception, and for each either log and/or output), there might be a bit too much new code (it covers all cases, the goal is to have none of these cases in the future) but part of it will be in the new error handling system anyway