Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forms): Add export and import functionality for service catalog configuration #18661

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(forms): Add export and import functionality for service catalog configuration #18661

wants to merge 4 commits into from

Conversation

ccailly
Copy link
Member

@ccailly ccailly commented Jan 6, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

Currently, form information relating to the service catalog is not exported and imported by the current system.

image

@ccailly ccailly self-assigned this Jan 6, 2025
@ccailly ccailly added the Forms label Jan 6, 2025
@ccailly ccailly added this to the 11.0.0 milestone Jan 6, 2025
AdrienClairembault
AdrienClairembault requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to import/export the illustration field.

@trasher
Copy link
Contributor

trasher commented Jan 7, 2025

I think you forgot to import/export the illustration field.

Maybe a test should ba added to ensure all fields (exepted explicitely excluded ones) are included.

@trasher
Copy link
Contributor

trasher commented Jan 9, 2025

e2e failure seems related to current PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@trasher trasher trasher approved these changes

@cedric-anne cedric-anne Awaiting requested review from cedric-anne

Assignees

@ccailly ccailly

Labels
Forms
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ccailly @trasher @AdrienClairembault