Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump scssphp/scssphp from 1.13.0 to 2.0.0 #18627

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2025

Bumps scssphp/scssphp from 1.13.0 to 2.0.0.

Release notes

Sourced from scssphp/scssphp's releases.

2.0.0

This release is a full rewrite of the compiler. The new implementation is a port of dart-sass, making it spec-compliant and easier to update to support new Sass features. However this release does not implement Sass modules yet.

BC breaks

  • The Compiler class is now final
  • The LoggerInterface now expects more argument in its method signatures
  • \ScssPhp\ScssPhp\OutputStyle is now an enum instead of a class with string constants.
  • Compiler::setOutputStyle now expects an instance of the OutputStyle enum instead of a string.
  • Deprecated methods of the compiler have been removed.

Deprecated

  • Deprecate passing a path as string as the Compiler::compileString second argument. Either pass a URL or use Compiler::compileFile instead. (@​stof)

Removed

  • Remove support for color math in Sass expressions (@​stof)
  • Remove the CLI shipped in the package (@​stof)
  • Remove the scss.inc.php file. Use the autoloader generated by Composer instead. (@​stof)
  • Remove the cache system integrated in the compiler (@​stof)
  • Remove support for PHP < 8.1 (@​stof)

Added

  • Add support for PHP 8.4 (@​stof)
  • Add support for the Sass indented syntax (@​stof)
  • Add a representation of Sass values using PHP value objects (@​stof)
  • Add the Importer extension point for custom importers (@​stof)
  • Add support for configuring the reporting of deprecation with Compiler::setSilencedDeprecations, Compiler::setFutureDeprecations and Compiler::setActiveDeprecations (@​stof)
  • Add support for silencing deprecations from dependencies with Compiler::setQuietDeps (@​stof)
  • Add support for configuring verbosity of deprecation warnings with Compiler::setVerbose (@​stof)

Fixed

  • Thanks to the rewrite, scssphp is now spec-compliant, fixing many issues (@​stof)

Changed

  • The message received by loggers no longer contains the location and stack trace. Loggers need to include them based on the provided argument depending on their formatting needs. (@​stof)
  • Custom functions can now be defined using the new representation of Sass values by using \ScssPhp\ScssPhp\Value\Value as return type. Untyped functions will still receive legacy values. (@​stof)
Commits
  • a70358e Merge pull request #778 from stof/prepare_release
  • 6443202 Prepare the 2.0.0 release
  • 785728d Merge pull request #777 from stof/clean_code
  • 33563f9 Modernize some code
  • 8d8511f Clean code of the Compiler
  • c6730b9 Merge pull request #776 from stof/update_signature
  • f9cb8b7 Update the signature of compileString to allow passing an importer
  • 5768c1a Merge pull request #775 from stof/clean_tests
  • cdab2a4 Remove tests for the extend logic in favor of sass-spec
  • 7196b4a Merge pull request #774 from stof/php8_4_compat
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Jan 1, 2025
@trasher
Copy link
Contributor

trasher commented Jan 6, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/composer/main/scssphp/scssphp-2.0.0 branch from 1b797fa to 37dea4d Compare January 6, 2025 14:52
@trasher
Copy link
Contributor

trasher commented Jan 7, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/composer/main/scssphp/scssphp-2.0.0 branch from 37dea4d to f069073 Compare January 7, 2025 06:52
@cedric-anne
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 9, 2025

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@cedric-anne
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 9, 2025

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@trasher
Copy link
Contributor

trasher commented Jan 10, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/composer/main/scssphp/scssphp-2.0.0 branch from f069073 to d714745 Compare January 10, 2025 06:57
@cedric-anne cedric-anne force-pushed the dependabot/composer/main/scssphp/scssphp-2.0.0 branch from d714745 to c6b2137 Compare January 13, 2025 14:57
Comment on lines +431 to +442
width: 217px;
background:
var(--tblr-body-bg) repeating-linear-gradient(
transparent,
transparent 21px,
var(--tblr-bg-surface-tertiary) 21px,
var(--tblr-bg-surface-tertiary) 42px
);
z-index: 1;
border: 1px solid var(--tblr-border-color);
float: left;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved them to fix the following deprecation:

DEPRECATION WARNING: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ,
431 | /     *,
432 | |     ::before,
433 | |     ::after {
434 | |         box-sizing: content-box;
435 | |     }
    | '--- nested rule
... |
445 |       width: 217px;
    |       ^^^^^^^^^^^^ declaration
    '
    css/includes/components/_racks.scss 445:5  @import
    css/includes/_includes.scss 60:9           @import
    css/glpi.scss 37:9                         @import
    css 1:9                                    root stylesheet

Comment on lines +115 to +121
@include font-size(calc(#{$input-font-size-sm} * 0.875));

min-height: $input-height-sm;
}

.form-select-lg + & {
@include font-size($input-font-size-lg * 0.875);
@include font-size(calc(#{$input-font-size-lg} * 0.875));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are fixing the following issue:

[ScssPhp\ScssPhp\Exception\SimpleSassRuntimeException]                   
  Undefined operation "calc(var(--tblr-body-font-size) * 0.875) * 0.875".  
      ,                                                                    
  115 |                 @include font-size($input-font-size-sm * 0.875);   
      |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^     
      '                                                                    
    css/includes/components/_select2.scss 115:36  @import                  
    css/install.scss 36:9                         @import                  
    css 1:9                                       root stylesheet          

css/standalone/gridstack-grids.scss Outdated Show resolved Hide resolved
dependabot bot and others added 3 commits January 13, 2025 21:10
Bumps [scssphp/scssphp](https://github.com/scssphp/scssphp) from 1.13.0 to 2.0.0.
- [Release notes](https://github.com/scssphp/scssphp/releases)
- [Commits](scssphp/scssphp@v1.13.0...v2.0.0)

---
updated-dependencies:
- dependency-name: scssphp/scssphp
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@cedric-anne cedric-anne force-pushed the dependabot/composer/main/scssphp/scssphp-2.0.0 branch from c6b2137 to 0387999 Compare January 13, 2025 20:10
@trasher trasher merged commit 0fa6e4c into main Jan 14, 2025
10 checks passed
@dependabot dependabot bot deleted the dependabot/composer/main/scssphp/scssphp-2.0.0 branch January 14, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants