Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Execute rules when a new tracking is received via the mail collector #18543

Closed
wants to merge 1 commit into from

Conversation

MyvTsv
Copy link
Contributor

@MyvTsv MyvTsv commented Dec 12, 2024

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

  • It fixes !35427
  • If the mail collector does not create a new ticket but creates a new follow-up, the ticket rules are not triggered.

Screenshots (if appropriate):

RuleTicket

@MyvTsv MyvTsv requested review from stonebuzz and Rom1-B December 12, 2024 09:50
@MyvTsv MyvTsv self-assigned this Dec 12, 2024
@stonebuzz
Copy link
Contributor

@MyvTsv
you have to discuss it IRL, for me it's a big change for MaillCollector (should be target main) and it's more a feature than a bug

Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @stonebuzz . Also, forcing a ticket update when there is no update is probably not the correct way to do it (would be way better for example to just "run " rules rather than updating anything.

@cedric-anne
Copy link
Member

The customer will not sponsor this new feature, I close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants